* Apply 9451c79bc39e610882bdd12370f01af5004a3c4f to linux-5.4.y
@ 2023-08-30 15:33 Nathan Chancellor
2023-08-30 15:39 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2023-08-30 15:33 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sasha Levin
Cc: stable, llvm, Nick Desaulniers, Michael Ellerman
Hi Greg and Sasha,
Please consider applying commit 9451c79bc39e ("powerpc/pmac/smp: Avoid
unused-variable warnings") to 5.4, as it resolves a build failure that
we see building ppc64_guest_defconfig with clang due to arch/powerpc
compiling with -Werror by default:
arch/powerpc/platforms/powermac/smp.c:664:26: error: unused variable 'core99_l2_cache' [-Werror,-Wunused-variable]
664 | volatile static long int core99_l2_cache;
| ^~~~~~~~~~~~~~~
arch/powerpc/platforms/powermac/smp.c:665:26: error: unused variable 'core99_l3_cache' [-Werror,-Wunused-variable]
665 | volatile static long int core99_l3_cache;
| ^~~~~~~~~~~~~~~
2 errors generated.
I have verified that it applies cleanly and does not appear to have any
direct follow up fixes, although commit a4037d1f1fc4 ("powerpc/pmac/smp:
Drop unnecessary volatile qualifier") was in the same area around the
same time so maybe it makes sense to take that one as well but I don't
think it has any functional impact.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Apply 9451c79bc39e610882bdd12370f01af5004a3c4f to linux-5.4.y
2023-08-30 15:33 Apply 9451c79bc39e610882bdd12370f01af5004a3c4f to linux-5.4.y Nathan Chancellor
@ 2023-08-30 15:39 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-08-30 15:39 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Sasha Levin, stable, llvm, Nick Desaulniers, Michael Ellerman
On Wed, Aug 30, 2023 at 08:33:42AM -0700, Nathan Chancellor wrote:
> Hi Greg and Sasha,
>
> Please consider applying commit 9451c79bc39e ("powerpc/pmac/smp: Avoid
> unused-variable warnings") to 5.4, as it resolves a build failure that
> we see building ppc64_guest_defconfig with clang due to arch/powerpc
> compiling with -Werror by default:
>
> arch/powerpc/platforms/powermac/smp.c:664:26: error: unused variable 'core99_l2_cache' [-Werror,-Wunused-variable]
> 664 | volatile static long int core99_l2_cache;
> | ^~~~~~~~~~~~~~~
> arch/powerpc/platforms/powermac/smp.c:665:26: error: unused variable 'core99_l3_cache' [-Werror,-Wunused-variable]
> 665 | volatile static long int core99_l3_cache;
> | ^~~~~~~~~~~~~~~
> 2 errors generated.
>
> I have verified that it applies cleanly and does not appear to have any
> direct follow up fixes, although commit a4037d1f1fc4 ("powerpc/pmac/smp:
> Drop unnecessary volatile qualifier") was in the same area around the
> same time so maybe it makes sense to take that one as well but I don't
> think it has any functional impact.
Now queued up.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-30 18:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-30 15:33 Apply 9451c79bc39e610882bdd12370f01af5004a3c4f to linux-5.4.y Nathan Chancellor
2023-08-30 15:39 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox