public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: "André Draszik" <git@andred.net>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org,
	"André Draszik" <andre.draszik@linaro.org>,
	"Bernd Schubert" <bschubert@ddn.com>,
	"Miklos Szeredi" <mszeredi@redhat.com>,
	stable@vger.kernel.org
Subject: [RESEND PATCH] Revert "fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT"
Date: Mon,  4 Sep 2023 14:33:21 +0100	[thread overview]
Message-ID: <20230904133321.104584-1-git@andred.net> (raw)

From: André Draszik <andre.draszik@linaro.org>

This reverts commit 3066ff93476c35679cb07a97cce37d9bb07632ff.

This patch breaks all existing userspace by requiring updates as
mentioned in the commit message, which is not allowed.

Revert to restore compatibility with existing userspace
implementations.

Cc: Bernd Schubert <bschubert@ddn.com>
Cc: Miklos Szeredi <mszeredi@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>

---
resend because of missing people in Cc
---
 fs/fuse/inode.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 549358ffea8b..0b966b0e0962 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1132,10 +1132,7 @@ static void process_init_reply(struct fuse_mount *fm, struct fuse_args *args,
 		process_init_limits(fc, arg);
 
 		if (arg->minor >= 6) {
-			u64 flags = arg->flags;
-
-			if (flags & FUSE_INIT_EXT)
-				flags |= (u64) arg->flags2 << 32;
+			u64 flags = arg->flags | (u64) arg->flags2 << 32;
 
 			ra_pages = arg->max_readahead / PAGE_SIZE;
 			if (flags & FUSE_ASYNC_READ)
-- 
2.40.1


             reply	other threads:[~2023-09-04 13:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 13:33 André Draszik [this message]
2023-09-04 13:41 ` [RESEND PATCH] Revert "fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT" Miklos Szeredi
2023-09-04 14:21   ` André Draszik
2023-09-04 14:45     ` Bernd Schubert
2023-10-18 11:15 ` [PATCH v2] " André Draszik
2023-10-18 11:39   ` Bernd Schubert
2023-10-18 11:46     ` André Draszik
2023-10-18 11:52       ` Bernd Schubert
2023-10-18 14:26         ` André Draszik
2023-10-18 14:40           ` Bernd Schubert
2023-10-18 15:51             ` Bernd Schubert
2023-10-25 11:30               ` Linux regression tracking (Thorsten Leemhuis)
2023-10-25 13:17                 ` Miklos Szeredi
2023-10-26  5:28                   ` Thorsten Leemhuis
2023-10-27 10:40                   ` Greg Kroah-Hartman
     [not found]                     ` <CAOssrKfNkMmHB2oHHO8gWbzDX27vS--e9dZoh_Mjv-17mSUTBw@mail.gmail.com>
     [not found]                       ` <2023102740-think-hatless-ab87@gregkh>
     [not found]                         ` <CAOssrKd-O1JKEPzvnM1VkQ0-oTpDv0RfY6B5oF5p63AtQ4HoqA@mail.gmail.com>
     [not found]                           ` <2023102757-cornflake-pry-e788@gregkh>
2023-10-27 18:23                             ` Miklos Szeredi
     [not found]                           ` <689f677b84b484636b673b362b17a6501a056968.camel@linaro.org>
     [not found]                             ` <CAOssrKfP+t-cy322ujizQofgZkPZsBu1H4+zfbWNEFCmTsXwug@mail.gmail.com>
     [not found]                               ` <afe378bf254f6c4ac73bb55be3fa7422f2da3f5f.camel@linaro.org>
     [not found]                                 ` <CAOssrKeJB7BZ7fA6Uqo6rHohybmgovc6rVwDeHbegvweSyZeeA@mail.gmail.com>
2023-11-01 12:36                                   ` Linux regression tracking (Thorsten Leemhuis)
2023-11-08 10:31                                     ` André Draszik
2023-11-08 12:18                                       ` Miklos Szeredi
2023-12-06 14:03                                       ` Linux regression tracking (Thorsten Leemhuis)
2023-10-22 13:35 ` [RESEND PATCH] " Linux regression tracking #adding (Thorsten Leemhuis)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230904133321.104584-1-git@andred.net \
    --to=git@andred.net \
    --cc=andre.draszik@linaro.org \
    --cc=bschubert@ddn.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox