From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3568EE14C3 for ; Thu, 7 Sep 2023 00:13:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239937AbjIGANh (ORCPT ); Wed, 6 Sep 2023 20:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbjIGANg (ORCPT ); Wed, 6 Sep 2023 20:13:36 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02C43199F; Wed, 6 Sep 2023 17:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694045613; x=1725581613; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WlkbumebDoiqA7h5lGLoCyy+L33WG8FJ86yAFQBnwlo=; b=Vp7byVcBnpciHmmv2yagdPIuOSlHuRf92rnKKRZJSxZGTzifHs4EGcTS FzYwv+usoYpyGZzAQ/TIaj2IG1+5IgnvjESqo8fhSSzP6MeUxv7NAQsjc R2e/c/TucrCs7G2I8+CCmYzMoGGsxbmynPAjd4kSVvjwCgMh+MyXbURiQ THoVW/qUgvDbBHie/fUo6uKCuIoYErJZpTY+vdaMsZ2d1yPCgXd1jUy9O nqizCcH5fGHqp1lCBgBFe7TnugF35bT9dLgBvJf7J4yzIBGmdHssaLlf4 ooNBoVSTH8mkl5paTiGdF8VVU/vTtdpXILoFP6MtJd1zGOGOM/obrsscX Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="374613201" X-IronPort-AV: E=Sophos;i="6.02,233,1688454000"; d="scan'208";a="374613201" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2023 17:13:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="856680657" X-IronPort-AV: E=Sophos;i="6.02,233,1688454000"; d="scan'208";a="856680657" Received: from lkp-server01.sh.intel.com (HELO 59b3c6e06877) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 06 Sep 2023 17:13:22 -0700 Received: from kbuild by 59b3c6e06877 with local (Exim 4.96) (envelope-from ) id 1qe2e8-0000j1-0U; Thu, 07 Sep 2023 00:13:20 +0000 Date: Thu, 7 Sep 2023 08:12:57 +0800 From: kernel test robot To: Jason Andryuk , Juergen Gross , Boris Ostrovsky , "Rafael J. Wysocki" , Len Brown Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Roger Pau Monne , stable@vger.kernel.org, Jason Andryuk , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2] acpi/processor: sanitize _PDC buffer bits when running as Xen dom0 Message-ID: <202309070741.2n0k8FjN-lkp@intel.com> References: <20230906182125.48642-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230906182125.48642-1-jandryuk@gmail.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Jason, kernel test robot noticed the following build errors: [auto build test ERROR on tip/x86/core] [also build test ERROR on v6.5] [cannot apply to rafael-pm/linux-next linus/master next-20230906] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jason-Andryuk/acpi-processor-sanitize-_PDC-buffer-bits-when-running-as-Xen-dom0/20230907-022235 base: tip/x86/core patch link: https://lore.kernel.org/r/20230906182125.48642-1-jandryuk%40gmail.com patch subject: [PATCH v2] acpi/processor: sanitize _PDC buffer bits when running as Xen dom0 config: i386-randconfig-003-20230907 (https://download.01.org/0day-ci/archive/20230907/202309070741.2n0k8FjN-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230907/202309070741.2n0k8FjN-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309070741.2n0k8FjN-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/acpi/processor_pdc.c:147:3: error: call to undeclared function 'xen_sanitize_pdc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] xen_sanitize_pdc(buffer); ^ 1 error generated. vim +/xen_sanitize_pdc +147 drivers/acpi/processor_pdc.c 116 117 /* 118 * _PDC is required for a BIOS-OS handshake for most of the newer 119 * ACPI processor features. 120 */ 121 static acpi_status 122 acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in) 123 { 124 acpi_status status = AE_OK; 125 union acpi_object *obj; 126 u32 *buffer = NULL; 127 128 obj = pdc_in->pointer; 129 buffer = (u32 *)(obj->buffer.pointer); 130 131 if (boot_option_idle_override == IDLE_NOMWAIT) { 132 /* 133 * If mwait is disabled for CPU C-states, the C2C3_FFH access 134 * mode will be disabled in the parameter of _PDC object. 135 * Of course C1_FFH access mode will also be disabled. 136 */ 137 buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH); 138 } 139 140 if (xen_initial_domain()) { 141 /* 142 * When Linux is running as Xen dom0, the hypervisor is the 143 * entity in charge of the processor power management, and so 144 * Xen needs to check the OS capabilities reported in the _PDC 145 * buffer matches what the hypervisor driver supports. 146 */ > 147 xen_sanitize_pdc(buffer); 148 } 149 150 status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL); 151 152 if (ACPI_FAILURE(status)) 153 acpi_handle_debug(handle, 154 "Could not evaluate _PDC, using legacy perf control\n"); 155 156 return status; 157 } 158 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki