* [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896
@ 2023-09-07 11:20 Frank Wunderlich
2023-09-07 11:36 ` AngeloGioacchino Del Regno
2023-09-13 8:35 ` Markus Schneider-Pargmann
0 siblings, 2 replies; 5+ messages in thread
From: Frank Wunderlich @ 2023-09-07 11:20 UTC (permalink / raw)
To: linux-mediatek
Cc: Frank Wunderlich, Rafael J. Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Matthias Brugger,
AngeloGioacchino Del Regno, Daniel Golle, linux-pm, linux-kernel,
linux-arm-kernel, stable
From: Frank Wunderlich <frank-w@public-files.de>
Reading thermal sensor on mt7986 devices returns invalid temperature:
bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
-274000
Fix this by adding missing members in mtk_thermal_data struct which were
used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
Cc: stable@vger.kernel.org
Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
drivers/thermal/mediatek/auxadc_thermal.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
index 843214d30bd8..967b9a1aead4 100644
--- a/drivers/thermal/mediatek/auxadc_thermal.c
+++ b/drivers/thermal/mediatek/auxadc_thermal.c
@@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_thermal_data = {
.adcpnp = mt7986_adcpnp,
.sensor_mux_values = mt7986_mux_values,
.version = MTK_THERMAL_V3,
+ .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1,
+ .apmixed_buffer_ctl_mask = GENMASK(31, 6) | BIT(3),
+ .apmixed_buffer_ctl_set = BIT(0),
};
static bool mtk_thermal_temp_is_valid(int temp)
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896
2023-09-07 11:20 [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896 Frank Wunderlich
@ 2023-09-07 11:36 ` AngeloGioacchino Del Regno
2023-09-13 8:35 ` Markus Schneider-Pargmann
1 sibling, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-09-07 11:36 UTC (permalink / raw)
To: Frank Wunderlich, linux-mediatek
Cc: Frank Wunderlich, Rafael J. Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Matthias Brugger, Daniel Golle,
linux-pm, linux-kernel, linux-arm-kernel, stable
Il 07/09/23 13:20, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Reading thermal sensor on mt7986 devices returns invalid temperature:
>
> bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
> -274000
>
> Fix this by adding missing members in mtk_thermal_data struct which were
> used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
>
> Cc: stable@vger.kernel.org
> Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896
2023-09-07 11:20 [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896 Frank Wunderlich
2023-09-07 11:36 ` AngeloGioacchino Del Regno
@ 2023-09-13 8:35 ` Markus Schneider-Pargmann
2024-01-31 5:17 ` Daniel Golle
1 sibling, 1 reply; 5+ messages in thread
From: Markus Schneider-Pargmann @ 2023-09-13 8:35 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-mediatek, Frank Wunderlich, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Matthias Brugger,
AngeloGioacchino Del Regno, Daniel Golle, linux-pm, linux-kernel,
linux-arm-kernel, stable
On Thu, Sep 07, 2023 at 01:20:18PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Reading thermal sensor on mt7986 devices returns invalid temperature:
>
> bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
> -274000
>
> Fix this by adding missing members in mtk_thermal_data struct which were
> used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
>
> Cc: stable@vger.kernel.org
> Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
Thanks for fixing!
Best,
Markus
> ---
> drivers/thermal/mediatek/auxadc_thermal.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> index 843214d30bd8..967b9a1aead4 100644
> --- a/drivers/thermal/mediatek/auxadc_thermal.c
> +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> @@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_thermal_data = {
> .adcpnp = mt7986_adcpnp,
> .sensor_mux_values = mt7986_mux_values,
> .version = MTK_THERMAL_V3,
> + .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1,
> + .apmixed_buffer_ctl_mask = GENMASK(31, 6) | BIT(3),
> + .apmixed_buffer_ctl_set = BIT(0),
> };
>
> static bool mtk_thermal_temp_is_valid(int temp)
> --
> 2.34.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896
2023-09-13 8:35 ` Markus Schneider-Pargmann
@ 2024-01-31 5:17 ` Daniel Golle
2024-01-31 8:08 ` Daniel Lezcano
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Golle @ 2024-01-31 5:17 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Frank Wunderlich, Markus Schneider-Pargmann, Rafael J. Wysocki,
linux-pm, Amit Kucheria, stable, linux-kernel, linux-mediatek,
Matthias Brugger, Zhang Rui, linux-arm-kernel,
AngeloGioacchino Del Regno
Hi everyone!
On Wed, Sep 13, 2023 at 10:35:29AM +0200, Markus Schneider-Pargmann wrote:
> On Thu, Sep 07, 2023 at 01:20:18PM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Reading thermal sensor on mt7986 devices returns invalid temperature:
> >
> > bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
> > -274000
> >
> > Fix this by adding missing members in mtk_thermal_data struct which were
> > used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
> Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Tested-by: Daniel Golle <daniel@makrotopia.org>
Kind ping to thermal and mediatek maintainers, please merge this patch.
https://patchwork.kernel.org/project/linux-pm/patch/20230907112018.52811-1-linux@fw-web.de/
https://patchwork.kernel.org/project/linux-mediatek/patch/20230907112018.52811-1-linux@fw-web.de/
>
> Thanks for fixing!
>
> Best,
> Markus
>
> > ---
> > drivers/thermal/mediatek/auxadc_thermal.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> > index 843214d30bd8..967b9a1aead4 100644
> > --- a/drivers/thermal/mediatek/auxadc_thermal.c
> > +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> > @@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_thermal_data = {
> > .adcpnp = mt7986_adcpnp,
> > .sensor_mux_values = mt7986_mux_values,
> > .version = MTK_THERMAL_V3,
> > + .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1,
> > + .apmixed_buffer_ctl_mask = GENMASK(31, 6) | BIT(3),
> > + .apmixed_buffer_ctl_set = BIT(0),
> > };
> >
> > static bool mtk_thermal_temp_is_valid(int temp)
> > --
> > 2.34.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896
2024-01-31 5:17 ` Daniel Golle
@ 2024-01-31 8:08 ` Daniel Lezcano
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2024-01-31 8:08 UTC (permalink / raw)
To: Daniel Golle
Cc: Frank Wunderlich, Markus Schneider-Pargmann, Rafael J. Wysocki,
linux-pm, Amit Kucheria, stable, linux-kernel, linux-mediatek,
Matthias Brugger, Zhang Rui, linux-arm-kernel,
AngeloGioacchino Del Regno
On 31/01/2024 06:17, Daniel Golle wrote:
> Hi everyone!
>
> On Wed, Sep 13, 2023 at 10:35:29AM +0200, Markus Schneider-Pargmann wrote:
>> On Thu, Sep 07, 2023 at 01:20:18PM +0200, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> Reading thermal sensor on mt7986 devices returns invalid temperature:
>>>
>>> bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp
>>> -274000
>>>
>>> Fix this by adding missing members in mtk_thermal_data struct which were
>>> used in mtk_thermal_turn_on_buffer after commit 33140e668b10.
>>>
>>> Cc: stable@vger.kernel.org
>>> Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>>
>> Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
>
> Reviewed-by: Daniel Golle <daniel@makrotopia.org>
> Tested-by: Daniel Golle <daniel@makrotopia.org>
>
> Kind ping to thermal and mediatek maintainers, please merge this patch.
Applied with master pong
Thanks!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-31 8:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-07 11:20 [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896 Frank Wunderlich
2023-09-07 11:36 ` AngeloGioacchino Del Regno
2023-09-13 8:35 ` Markus Schneider-Pargmann
2024-01-31 5:17 ` Daniel Golle
2024-01-31 8:08 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox