Kernel 6.5 black screen regression

Kernel 6.5 black screen regression

[Mario Limonciello]

Hi,

The following patch fixes a regression reported by Michael Larabel on an 
Acer Phoenix laptop where there is a black screen in GNOME with kernel 6.5.

It's marked CC to stable, but I checked the stable queue and didn't see 
it so I wanted to make sure it wasn't missed.

a7c0cad0dc06 ("drm/amd/display: ensure async flips are only accepted for 
fast updates")

Reported-by: Michael Larabel <Michael@MichaelLarabel.com>

Thanks!

Re: Kernel 6.5 black screen regression

[Greg KH]

On Wed, Sep 06, 2023 at 12:55:29PM -0500, Mario Limonciello wrote:
> Hi,
> 
> The following patch fixes a regression reported by Michael Larabel on an
> Acer Phoenix laptop where there is a black screen in GNOME with kernel 6.5.
> 
> It's marked CC to stable, but I checked the stable queue and didn't see it
> so I wanted to make sure it wasn't missed.

The fixes tag in that commit is odd, it says it fixes something that is
NOT in 6.5, so are you sure about this?

> a7c0cad0dc06 ("drm/amd/display: ensure async flips are only accepted for
> fast updates")
> 
> Reported-by: Michael Larabel <Michael@MichaelLarabel.com>

Ok, now queued up, thanks.

greg k-h

Re: Kernel 6.5 black screen regression

[Mario Limonciello]

On 9/7/2023 05:13, Greg KH wrote:
> On Wed, Sep 06, 2023 at 12:55:29PM -0500, Mario Limonciello wrote:
>> Hi,
>>
>> The following patch fixes a regression reported by Michael Larabel on an
>> Acer Phoenix laptop where there is a black screen in GNOME with kernel 6.5.
>>
>> It's marked CC to stable, but I checked the stable queue and didn't see it
>> so I wanted to make sure it wasn't missed.
> 
> The fixes tag in that commit is odd, it says it fixes something that is
> NOT in 6.5, so are you sure about this?
> 

I believe it's one of those cases that the same commit landed twice. So 
the wrong SHA got added to the fixes tag.

This is the one it should have been:

1ca67aba8d11 ("drm/amd/display: only accept async flips for fast updates")

>> a7c0cad0dc06 ("drm/amd/display: ensure async flips are only accepted for
>> fast updates")
>>
>> Reported-by: Michael Larabel <Michael@MichaelLarabel.com>
> 
> Ok, now queued up, thanks.

Thanks!

Seeing the correct sha1; I find the problematic one backported to:

* 6.4.7 as cd013a58cf64 ("drm/amd/display: only accept async flips for 
fast updates")

and

* 6.1.42 as 438542074174 ("drm/amd/display: only accept async flips for 
fast updates")

Did you only queue for 6.5.y?  If so, can you please add to 6.1.y and 
6.4.y as well?

Thanks!

Re: Kernel 6.5 black screen regression

[Greg KH]

On Thu, Sep 07, 2023 at 09:06:15AM -0500, Mario Limonciello wrote:
> On 9/7/2023 05:13, Greg KH wrote:
> > On Wed, Sep 06, 2023 at 12:55:29PM -0500, Mario Limonciello wrote:
> > > Hi,
> > > 
> > > The following patch fixes a regression reported by Michael Larabel on an
> > > Acer Phoenix laptop where there is a black screen in GNOME with kernel 6.5.
> > > 
> > > It's marked CC to stable, but I checked the stable queue and didn't see it
> > > so I wanted to make sure it wasn't missed.
> > 
> > The fixes tag in that commit is odd, it says it fixes something that is
> > NOT in 6.5, so are you sure about this?
> > 
> 
> I believe it's one of those cases that the same commit landed twice. So the
> wrong SHA got added to the fixes tag.
> 
> This is the one it should have been:
> 
> 1ca67aba8d11 ("drm/amd/display: only accept async flips for fast updates")
> 
> > > a7c0cad0dc06 ("drm/amd/display: ensure async flips are only accepted for
> > > fast updates")
> > > 
> > > Reported-by: Michael Larabel <Michael@MichaelLarabel.com>
> > 
> > Ok, now queued up, thanks.
> 
> Thanks!
> 
> Seeing the correct sha1; I find the problematic one backported to:
> 
> * 6.4.7 as cd013a58cf64 ("drm/amd/display: only accept async flips for fast
> updates")
> 
> and
> 
> * 6.1.42 as 438542074174 ("drm/amd/display: only accept async flips for fast
> updates")
> 
> Did you only queue for 6.5.y?  If so, can you please add to 6.1.y and 6.4.y
> as well?

Ok, now queued up there too, thanks.

greg k-h