From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65EBBEEB565 for ; Sat, 9 Sep 2023 00:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346023AbjIIAot (ORCPT ); Fri, 8 Sep 2023 20:44:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343620AbjIIAoN (ORCPT ); Fri, 8 Sep 2023 20:44:13 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 237C8469D; Fri, 8 Sep 2023 17:41:39 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3804CC116B1; Sat, 9 Sep 2023 00:41:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694220087; bh=shA24TvF1qh5fZrwtCNqmihAD9Z9Ku+iFVEu3/+rc5o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OaCiMtVZW3i8bu6WgvG38ry6BGsdkeqXq2U+24ZtnA64EUAn69kAfQCTzvegEuuke CIVmtxBBSAeLssyVo6ajkPuW8s1/I6yXmB8BHroXQX2a7VXq0c3HNRJpw80/e/S9tX /b2jw7ol6PHrZe6PC88FIX54ec/FBh799Hj/q83WG3NxaHrBQRxN844ZTGFXX1TBkS FElt/xCky0RbBI8s6x4YabSWSTQ9SsDbZcFxgOwmW+SiuYpMYwZMkY5wIF2zqh23aG tHPUEdu30jz1gq+up2N5vGP7ZGtHxGloDOhphYF9cjYYQDT3UUp2MyhQSKJatW3/ED Z0AKC/wTti5XA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhang Shurong , Hans Verkuil , Sasha Levin , crope@iki.fi, mchehab@kernel.org, linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 04/12] media: anysee: fix null-ptr-deref in anysee_master_xfer Date: Fri, 8 Sep 2023 20:41:07 -0400 Message-Id: <20230909004115.3581195-4-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230909004115.3581195-1-sashal@kernel.org> References: <20230909004115.3581195-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.325 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhang Shurong [ Upstream commit c30411266fd67ea3c02a05c157231654d5a3bdc9 ] In anysee_master_xfer, msg is controlled by user. When msg[i].buf is null and msg[i].len is zero, former checks on msg[i].buf would be passed. Malicious data finally reach anysee_master_xfer. If accessing msg[i].buf[0] without sanity check, null ptr deref would happen. We add check on msg[i].len to prevent crash. Similar commit: commit 0ed554fd769a ("media: dvb-usb: az6027: fix null-ptr-deref in az6027_i2c_xfer()") Signed-off-by: Zhang Shurong Signed-off-by: Hans Verkuil [hverkuil: add spaces around +] Signed-off-by: Sasha Levin --- drivers/media/usb/dvb-usb-v2/anysee.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c index 20ee7eea2a91e..83af86505363b 100644 --- a/drivers/media/usb/dvb-usb-v2/anysee.c +++ b/drivers/media/usb/dvb-usb-v2/anysee.c @@ -211,7 +211,7 @@ static int anysee_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, while (i < num) { if (num > i + 1 && (msg[i+1].flags & I2C_M_RD)) { - if (msg[i].len > 2 || msg[i+1].len > 60) { + if (msg[i].len != 2 || msg[i + 1].len > 60) { ret = -EOPNOTSUPP; break; } -- 2.40.1