* [PATCH] USB: add ignore remote wakeup quirk for one of Logitech's receivers
@ 2023-09-10 16:37 Hamza Mahfooz
2023-09-11 7:32 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Hamza Mahfooz @ 2023-09-10 16:37 UTC (permalink / raw)
To: linux-usb
Cc: Hamza Mahfooz, stable, Greg Kroah-Hartman, Alan Stern,
Benjamin Tissoires, Bastien Nocera, Hans de Goede,
Łukasz Bartosik, Nicolas Dumazet, Jean-Francois Le Fillatre,
Mark Pearson, Hannu Hartikainen, linux-kernel
This device causes the system to wake up from suspend, as soon as it
enters it (even if the device attached to the receiver is powered off).
So, ignore remote wakeup events from it.
Cc: stable@vger.kernel.org
Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
---
drivers/usb/core/quirks.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 15e9bd180a1d..d2e2a2873f34 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -264,6 +264,10 @@ static const struct usb_device_id usb_quirk_list[] = {
/* Logitech Harmony 700-series */
{ USB_DEVICE(0x046d, 0xc122), .driver_info = USB_QUIRK_DELAY_INIT },
+ /* Logitech lightspeed receiver (0xc547) */
+ { USB_DEVICE(0x046d, 0xc547), .driver_info =
+ USB_QUIRK_IGNORE_REMOTE_WAKEUP },
+
/* Philips PSC805 audio device */
{ USB_DEVICE(0x0471, 0x0155), .driver_info = USB_QUIRK_RESET_RESUME },
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] USB: add ignore remote wakeup quirk for one of Logitech's receivers
2023-09-10 16:37 [PATCH] USB: add ignore remote wakeup quirk for one of Logitech's receivers Hamza Mahfooz
@ 2023-09-11 7:32 ` Hans de Goede
2023-09-11 15:19 ` Hamza Mahfooz
0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2023-09-11 7:32 UTC (permalink / raw)
To: Hamza Mahfooz, linux-usb
Cc: stable, Greg Kroah-Hartman, Alan Stern, Benjamin Tissoires,
Bastien Nocera, Łukasz Bartosik, Nicolas Dumazet,
Jean-Francois Le Fillatre, Mark Pearson, Hannu Hartikainen,
linux-kernel
Hi Hamza,
On 9/10/23 18:37, Hamza Mahfooz wrote:
> This device causes the system to wake up from suspend, as soon as it
> enters it (even if the device attached to the receiver is powered off).
> So, ignore remote wakeup events from it.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
> ---
> drivers/usb/core/quirks.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 15e9bd180a1d..d2e2a2873f34 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -264,6 +264,10 @@ static const struct usb_device_id usb_quirk_list[] = {
> /* Logitech Harmony 700-series */
> { USB_DEVICE(0x046d, 0xc122), .driver_info = USB_QUIRK_DELAY_INIT },
>
> + /* Logitech lightspeed receiver (0xc547) */
> + { USB_DEVICE(0x046d, 0xc547), .driver_info =
> + USB_QUIRK_IGNORE_REMOTE_WAKEUP },
> +
> /* Philips PSC805 audio device */
> { USB_DEVICE(0x0471, 0x0155), .driver_info = USB_QUIRK_RESET_RESUME },
>
If this is a lightspeed receiver then it really should be handled by
hid-logitech-dj.c unless this new receiver is using a new protocol ?
I wonder if adding it there also fixes the remote
wakeup issue (I doubt it fixes it but worth a try) ?
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] USB: add ignore remote wakeup quirk for one of Logitech's receivers
2023-09-11 7:32 ` Hans de Goede
@ 2023-09-11 15:19 ` Hamza Mahfooz
2023-09-11 15:29 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Hamza Mahfooz @ 2023-09-11 15:19 UTC (permalink / raw)
To: Hans de Goede
Cc: linux-usb, stable, Greg Kroah-Hartman, Alan Stern,
Benjamin Tissoires, Bastien Nocera, Łukasz Bartosik,
Nicolas Dumazet, Jean-Francois Le Fillatre, Mark Pearson,
Hannu Hartikainen, linux-kernel
Hey Hans,
On Mon, Sep 11 2023 at 09:32:42 AM +02:00:00, Hans de Goede
<hdegoede@redhat.com> wrote:
> Hi Hamza,
>
> On 9/10/23 18:37, Hamza Mahfooz wrote:
>> This device causes the system to wake up from suspend, as soon as it
>> enters it (even if the device attached to the receiver is powered
>> off).
>> So, ignore remote wakeup events from it.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
>> ---
>> drivers/usb/core/quirks.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> index 15e9bd180a1d..d2e2a2873f34 100644
>> --- a/drivers/usb/core/quirks.c
>> +++ b/drivers/usb/core/quirks.c
>> @@ -264,6 +264,10 @@ static const struct usb_device_id
>> usb_quirk_list[] = {
>> /* Logitech Harmony 700-series */
>> { USB_DEVICE(0x046d, 0xc122), .driver_info = USB_QUIRK_DELAY_INIT
>> },
>>
>> + /* Logitech lightspeed receiver (0xc547) */
>> + { USB_DEVICE(0x046d, 0xc547), .driver_info =
>> + USB_QUIRK_IGNORE_REMOTE_WAKEUP },
>> +
>> /* Philips PSC805 audio device */
>> { USB_DEVICE(0x0471, 0x0155), .driver_info =
>> USB_QUIRK_RESET_RESUME },
>>
>
> If this is a lightspeed receiver then it really should be handled by
> hid-logitech-dj.c unless this new receiver is using a new protocol ?
>
> I wonder if adding it there also fixes the remote
> wakeup issue (I doubt it fixes it but worth a try) ?
Seems like the following series does indeed fix this issue:
https://lore.kernel.org/linux-input/20230716182320.85483-1-mavchatz@protonmail.com/T/#u
>
> Regards,
>
> Hans
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] USB: add ignore remote wakeup quirk for one of Logitech's receivers
2023-09-11 15:19 ` Hamza Mahfooz
@ 2023-09-11 15:29 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2023-09-11 15:29 UTC (permalink / raw)
To: Hamza Mahfooz
Cc: linux-usb, stable, Greg Kroah-Hartman, Alan Stern,
Benjamin Tissoires, Bastien Nocera, Łukasz Bartosik,
Nicolas Dumazet, Jean-Francois Le Fillatre, Mark Pearson,
Hannu Hartikainen, linux-kernel
Hi Hamza,
On 9/11/23 17:19, Hamza Mahfooz wrote:
> Hey Hans,
>
> On Mon, Sep 11 2023 at 09:32:42 AM +02:00:00, Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi Hamza,
>>
>> On 9/10/23 18:37, Hamza Mahfooz wrote:
>>> This device causes the system to wake up from suspend, as soon as it
>>> enters it (even if the device attached to the receiver is powered off).
>>> So, ignore remote wakeup events from it.
>>>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
>>> ---
>>> drivers/usb/core/quirks.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>>> index 15e9bd180a1d..d2e2a2873f34 100644
>>> --- a/drivers/usb/core/quirks.c
>>> +++ b/drivers/usb/core/quirks.c
>>> @@ -264,6 +264,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>>> /* Logitech Harmony 700-series */
>>> { USB_DEVICE(0x046d, 0xc122), .driver_info = USB_QUIRK_DELAY_INIT },
>>>
>>> + /* Logitech lightspeed receiver (0xc547) */
>>> + { USB_DEVICE(0x046d, 0xc547), .driver_info =
>>> + USB_QUIRK_IGNORE_REMOTE_WAKEUP },
>>> +
>>> /* Philips PSC805 audio device */
>>> { USB_DEVICE(0x0471, 0x0155), .driver_info = USB_QUIRK_RESET_RESUME },
>>>
>>
>> If this is a lightspeed receiver then it really should be handled by
>> hid-logitech-dj.c unless this new receiver is using a new protocol ?
>>
>> I wonder if adding it there also fixes the remote
>> wakeup issue (I doubt it fixes it but worth a try) ?
>
>
> Seems like the following series does indeed fix this issue:
> https://lore.kernel.org/linux-input/20230716182320.85483-1-mavchatz@protonmail.com/T/#u
Great, thank you for letting us know that this is resolved with
that patch series.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-11 22:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-10 16:37 [PATCH] USB: add ignore remote wakeup quirk for one of Logitech's receivers Hamza Mahfooz
2023-09-11 7:32 ` Hans de Goede
2023-09-11 15:19 ` Hamza Mahfooz
2023-09-11 15:29 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox