From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B52CA0ED1 for ; Mon, 11 Sep 2023 21:56:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354143AbjIKVwg (ORCPT ); Mon, 11 Sep 2023 17:52:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239832AbjIKO34 (ORCPT ); Mon, 11 Sep 2023 10:29:56 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CBDBF0 for ; Mon, 11 Sep 2023 07:29:51 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD74BC433C7; Mon, 11 Sep 2023 14:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1694442591; bh=jNwsntOPTASt6w+7Sik8WYy75YVzkby2yOw/No3gDso=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hQVn6IJFidZEnRE9L39Cbu/SaETACvppYjhIIytwXeJj/eHVsrNWr4IMGTtMQZW1j fQSBoNIPkHPLRoakO28tdd3mqhbZt+xPSJJ2iDYF8I1cX/bnx0otXIL7pWeyCtcRv/ r5O84Tm/SVH6c5QmC/4ZwqLUJ15WbT0BsiJNx/7E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhu Wang , Helge Deller , Sasha Levin Subject: [PATCH 6.4 078/737] fbdev: goldfishfb: Do not check 0 for platform_get_irq() Date: Mon, 11 Sep 2023 15:38:57 +0200 Message-ID: <20230911134652.691487067@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230911134650.286315610@linuxfoundation.org> References: <20230911134650.286315610@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 6.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhu Wang [ Upstream commit 0650d5098f8b6b232cd5ea0e15437fc38f7d63ba ] Since platform_get_irq() never returned zero, so it need not to check whether it returned zero, and we use the return error code of platform_get_irq() to replace the current return error code. Please refer to the commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid") to get that platform_get_irq() never returned zero. Signed-off-by: Zhu Wang Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/goldfishfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c index 6fa2108fd912d..e41c9fef4a3b6 100644 --- a/drivers/video/fbdev/goldfishfb.c +++ b/drivers/video/fbdev/goldfishfb.c @@ -203,8 +203,8 @@ static int goldfish_fb_probe(struct platform_device *pdev) } fb->irq = platform_get_irq(pdev, 0); - if (fb->irq <= 0) { - ret = -ENODEV; + if (fb->irq < 0) { + ret = fb->irq; goto err_no_irq; } -- 2.40.1