From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D859CA0EC8 for ; Mon, 11 Sep 2023 21:48:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353690AbjIKVsG (ORCPT ); Mon, 11 Sep 2023 17:48:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240860AbjIKOzy (ORCPT ); Mon, 11 Sep 2023 10:55:54 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E598C118 for ; Mon, 11 Sep 2023 07:55:49 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28E77C433C8; Mon, 11 Sep 2023 14:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1694444149; bh=aXydvdwLnMpw6D+J0CJ4SeBxaRD9C9Jkw5cuwqWncEk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wEqnABnUBwuaSQVGUURO+K9V+0iXJj1szK+DkfbsbGq53kHfaQjjUzG5TqldGQZ+q NCF+Va1lwJdNqC9bFQzHN5ASb79sJ2YFNFtrwWVHj8u5VegW9O76NaNydlk+wtX+KE KaGkzOppd4ZbxwjK+aZQglLk1I3mWYqYxVkOlyZA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Andy Shevchenko , Lee Jones , Sasha Levin Subject: [PATCH 6.4 610/737] leds: pwm: Fix error code in led_pwm_create_fwnode() Date: Mon, 11 Sep 2023 15:47:49 +0200 Message-ID: <20230911134707.571516322@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230911134650.286315610@linuxfoundation.org> References: <20230911134650.286315610@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 6.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit cadb2de2a7fd9e955381307de3eddfcc386c208e ] Negative -EINVAL was intended, not positive EINVAL. Fix it. Fixes: 95138e01275e ("leds: pwm: Make error handling more robust") Signed-off-by: Dan Carpenter Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/leds/leds-pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c index 29194cc382afb..87c199242f3c8 100644 --- a/drivers/leds/leds-pwm.c +++ b/drivers/leds/leds-pwm.c @@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv) led.name = to_of_node(fwnode)->name; if (!led.name) { - ret = EINVAL; + ret = -EINVAL; goto err_child_out; } -- 2.40.1