From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D49BCA0ECF for ; Mon, 11 Sep 2023 22:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231295AbjIKWui (ORCPT ); Mon, 11 Sep 2023 18:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239543AbjIKOXb (ORCPT ); Mon, 11 Sep 2023 10:23:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44D22DE for ; Mon, 11 Sep 2023 07:23:27 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AA2BC433C7; Mon, 11 Sep 2023 14:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1694442206; bh=t2+dNxsqc1b+FbjZ8GIFxJyDGKk0y6Rldb8MqquwHwM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cLSBT2MU5d5L8b+O6GO9oZ3ssguqfSwuH5r4JnEP1K8m155aU+9UgTUBwmMyUrFyV yr/wlQsafRAfE1wvbVVSwhtRpyf8vYawC5W9Oh3HgESMVya3lWlMZ7W1o9bh8uQuI+ +n/PS5zO/NbYkYVh2q/8ShrKN0M2UnYo7/8KMy3o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kalle Valo , Ross Lagerwall , Bjorn Helgaas Subject: [PATCH 6.5 684/739] PCI: Free released resource after coalescing Date: Mon, 11 Sep 2023 15:48:03 +0200 Message-ID: <20230911134710.203104238@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230911134650.921299741@linuxfoundation.org> References: <20230911134650.921299741@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 6.5-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ross Lagerwall commit 8ec9c1d5d0a5a4744516adb483b97a238892f9d5 upstream. release_resource() doesn't actually free the resource or resource list entry so free the resource list entry to avoid a leak. Closes: https://lore.kernel.org/r/878r9sga1t.fsf@kernel.org/ Fixes: e54223275ba1 ("PCI: Release resource invalidated by coalescing") Link: https://lore.kernel.org/r/20230906110846.225369-1-ross.lagerwall@citrix.com Reported-by: Kalle Valo Tested-by: Kalle Valo Signed-off-by: Ross Lagerwall Signed-off-by: Bjorn Helgaas Cc: stable@vger.kernel.org # v5.16+ Signed-off-by: Greg Kroah-Hartman --- drivers/pci/probe.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -998,6 +998,7 @@ static int pci_register_host_bridge(stru res = window->res; if (!res->flags && !res->start && !res->end) { release_resource(res); + resource_list_destroy_entry(window); continue; }