From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA2ECD3424 for ; Sun, 17 Sep 2023 19:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240136AbjIQTxJ (ORCPT ); Sun, 17 Sep 2023 15:53:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240273AbjIQTwv (ORCPT ); Sun, 17 Sep 2023 15:52:51 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56CE7CCD for ; Sun, 17 Sep 2023 12:52:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0791AC43391; Sun, 17 Sep 2023 19:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1694980347; bh=DRNzDjuz58UPgdlagqVhmj1gnzS7t4mFD7dNkJd0J5s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xgafEq35NghabZw7JP96KI69nnBJ5i1CcbLo848cip2LOqVijzs2rlQZxyE/HZoRz cJGVkWIT5BArds3OyOBW1j0eb2guTE6AwhrYaxfMWzyjpeeFmUTrYwIT5qA2Mtp55m Lo5IfKJLpoQI84TKlK6Azc36j0b2/rbTPz/Bz1Wk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kuniyuki Iwashima , Eric Dumazet , "David S. Miller" , Sasha Levin Subject: [PATCH 6.5 137/285] af_unix: Fix data race around sk->sk_err. Date: Sun, 17 Sep 2023 21:12:17 +0200 Message-ID: <20230917191056.407996261@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230917191051.639202302@linuxfoundation.org> References: <20230917191051.639202302@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 6.5-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kuniyuki Iwashima [ Upstream commit b192812905e4b134f7b7994b079eb647e9d2d37e ] As with sk->sk_shutdown shown in the previous patch, sk->sk_err can be read locklessly by unix_dgram_sendmsg(). Let's use READ_ONCE() for sk_err as well. Note that the writer side is marked by commit cc04410af7de ("af_unix: annotate lockless accesses to sk->sk_err"). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/core/sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sock.c b/net/core/sock.c index 2a78e47f76dba..29c6cb030818b 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2748,7 +2748,7 @@ static long sock_wait_for_wmem(struct sock *sk, long timeo) break; if (READ_ONCE(sk->sk_shutdown) & SEND_SHUTDOWN) break; - if (sk->sk_err) + if (READ_ONCE(sk->sk_err)) break; timeo = schedule_timeout(timeo); } -- 2.40.1