From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5430CCD13D8 for ; Sun, 17 Sep 2023 19:37:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239770AbjIQThG (ORCPT ); Sun, 17 Sep 2023 15:37:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239842AbjIQTgt (ORCPT ); Sun, 17 Sep 2023 15:36:49 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9271B103 for ; Sun, 17 Sep 2023 12:36:43 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA508C433C8; Sun, 17 Sep 2023 19:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1694979403; bh=XOZavLPbbakxHeH0x4PGyvhtkzS2PlkbDnbWLv1NEFQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P7JTOqdYXXPCSVwGiaw8hN65b6lTosvVzjPlBGGPmKBv9CC//wOpGNlZKldK/Igbk dkegl9d5hW/mhUw8DriZLAPUVnMqyBC6kgq5QtNPWMEEZgixPoibLkGSC6A8fJg5UC QkERWIX+1QPyw77zBAz+Xl0HqQ9v9L/dy7XoHSaE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Bourgoin , Herbert Xu Subject: [PATCH 5.10 302/406] crypto: stm32 - fix loop iterating through scatterlist for DMA Date: Sun, 17 Sep 2023 21:12:36 +0200 Message-ID: <20230917191109.284549879@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230917191101.035638219@linuxfoundation.org> References: <20230917191101.035638219@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Bourgoin commit d9c83f71eeceed2cb54bb78be84f2d4055fd9a1f upstream. We were reading the length of the scatterlist sg after copying value of tsg inside. So we are using the size of the previous scatterlist and for the first one we are using an unitialised value. Fix this by copying tsg in sg[0] before reading the size. Fixes : 8a1012d3f2ab ("crypto: stm32 - Support for STM32 HASH module") Cc: stable@vger.kernel.org Signed-off-by: Thomas Bourgoin Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/stm32/stm32-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/crypto/stm32/stm32-hash.c +++ b/drivers/crypto/stm32/stm32-hash.c @@ -564,9 +564,9 @@ static int stm32_hash_dma_send(struct st } for_each_sg(rctx->sg, tsg, rctx->nents, i) { + sg[0] = *tsg; len = sg->length; - sg[0] = *tsg; if (sg_is_last(sg)) { if (hdev->dma_mode == 1) { len = (ALIGN(sg->length, 16) - 16);