From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5402CD13CF for ; Sun, 17 Sep 2023 19:43:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239871AbjIQTm5 (ORCPT ); Sun, 17 Sep 2023 15:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239935AbjIQTmb (ORCPT ); Sun, 17 Sep 2023 15:42:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AC011B8 for ; Sun, 17 Sep 2023 12:42:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 059B3C433CB; Sun, 17 Sep 2023 19:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1694979721; bh=hpATzd7nE4lsaEEUFJBSnx47npLiapextnnGoRcuCKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MHaEAFUis1BOX+NAtQSD8IxZuxUP+O4LZLBtaqRiroM12cAYiJoa2mQtx6IeEMDAo vNdqJCEI2Yvvhl3x+xNcD8Fy5dMHvWHJOTkls5zAGArjLV/oxluWtTzzNjCAZKv4yT fMNAZ2pd9u0yVIwBfm8HZooPfSkhC8VbnHvD0K7g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andy Shevchenko , Harald Freudenberger , Heiko Carstens , Sasha Levin Subject: [PATCH 5.10 360/406] s390/zcrypt: dont leak memory if dev_set_name() fails Date: Sun, 17 Sep 2023 21:13:34 +0200 Message-ID: <20230917191110.781429368@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230917191101.035638219@linuxfoundation.org> References: <20230917191101.035638219@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andy Shevchenko [ Upstream commit 6252f47b78031979ad919f971dc8468b893488bd ] When dev_set_name() fails, zcdn_create() doesn't free the newly allocated resources. Do it. Fixes: 00fab2350e6b ("s390/zcrypt: multiple zcrypt device nodes support") Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20230831110000.24279-1-andriy.shevchenko@linux.intel.com Signed-off-by: Harald Freudenberger Signed-off-by: Heiko Carstens Signed-off-by: Sasha Levin --- drivers/s390/crypto/zcrypt_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c index 3b9eda311c273..b518009715eeb 100644 --- a/drivers/s390/crypto/zcrypt_api.c +++ b/drivers/s390/crypto/zcrypt_api.c @@ -399,6 +399,7 @@ static int zcdn_create(const char *name) ZCRYPT_NAME "_%d", (int) MINOR(devt)); nodename[sizeof(nodename)-1] = '\0'; if (dev_set_name(&zcdndev->device, nodename)) { + kfree(zcdndev); rc = -EINVAL; goto unlockout; } -- 2.40.1