From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E482CD13D8 for ; Sun, 17 Sep 2023 20:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241041AbjIQUbc (ORCPT ); Sun, 17 Sep 2023 16:31:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241087AbjIQUbP (ORCPT ); Sun, 17 Sep 2023 16:31:15 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 977CCAF for ; Sun, 17 Sep 2023 13:31:10 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEEFCC433C8; Sun, 17 Sep 2023 20:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1694982670; bh=0El2Smv/EsU6muGleEEqJegEXRt3e9n3oOi0t9RPs8E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NEvxJOWiVzkEDgrLna7n/FC0YU+/NfseciWXHgRMHLxCp3uYT+9qE/kBRbaoEmiK8 fey9EVRYn/16Y5pY8KDN6mS8l7I+YrSxMNdDL4gB9OWlRPGSbbGKd4dfMLkiZh2+12 aqKbaMwS+nPq4i/dZNtTfqgAsXf82pCbUwatDUWo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lucas Leong , Wander Lairson Costa , Pablo Neira Ayuso Subject: [PATCH 5.15 319/511] netfilter: xt_sctp: validate the flag_info count Date: Sun, 17 Sep 2023 21:12:26 +0200 Message-ID: <20230917191121.523649761@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230917191113.831992765@linuxfoundation.org> References: <20230917191113.831992765@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wander Lairson Costa commit e99476497687ef9e850748fe6d232264f30bc8f9 upstream. sctp_mt_check doesn't validate the flag_count field. An attacker can take advantage of that to trigger a OOB read and leak memory information. Add the field validation in the checkentry function. Fixes: 2e4e6a17af35 ("[NETFILTER] x_tables: Abstraction layer for {ip,ip6,arp}_tables") Cc: stable@vger.kernel.org Reported-by: Lucas Leong Signed-off-by: Wander Lairson Costa Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/netfilter/xt_sctp.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/netfilter/xt_sctp.c +++ b/net/netfilter/xt_sctp.c @@ -150,6 +150,8 @@ static int sctp_mt_check(const struct xt { const struct xt_sctp_info *info = par->matchinfo; + if (info->flag_count > ARRAY_SIZE(info->flag_info)) + return -EINVAL; if (info->flags & ~XT_SCTP_VALID_FLAGS) return -EINVAL; if (info->invflags & ~XT_SCTP_VALID_FLAGS)