From: Greg KH <gregkh@linuxfoundation.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: Only fiddle with CHECKFLAGS if `need-compiler'
Date: Sun, 17 Sep 2023 09:02:58 +0200 [thread overview]
Message-ID: <2023091744-blank-bulge-01bf@gregkh> (raw)
In-Reply-To: <alpine.DEB.2.21.2309161613540.57368@angie.orcam.me.uk>
On Sat, Sep 16, 2023 at 04:19:40PM +0100, Maciej W. Rozycki wrote:
> commit 4fe4a6374c4db9ae2b849b61e84b58685dca565a upstream.
>
> We have originally guarded fiddling with CHECKFLAGS in our arch Makefile
> by checking for the CONFIG_MIPS variable, not set for targets such as
> `distclean', etc. that neither include `.config' nor use the compiler.
>
> Starting from commit 805b2e1d427a ("kbuild: include Makefile.compiler
> only when compiler is needed") we have had a generic `need-compiler'
> variable explicitly telling us if the compiler will be used and thus its
> capabilities need to be checked and expressed in the form of compilation
> flags. If this variable is not set, then `make' functions such as
> `cc-option' are undefined, causing all kinds of weirdness to happen if
> we expect specific results to be returned, most recently:
>
> cc1: error: '-mloongson-mmi' must be used with '-mhard-float'
>
> messages with configurations such as `fuloong2e_defconfig' and the
> `modules_install' target, which does include `.config' and yet does not
> use the compiler.
>
> Replace the check for CONFIG_MIPS with one for `need-compiler' instead,
> so as to prevent the compiler from being ever called for CHECKFLAGS when
> not needed.
>
> Reported-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> Closes: https://lore.kernel.org/r/85031c0c-d981-031e-8a50-bc4fad2ddcd8@collabora.com/
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> Fixes: 805b2e1d427a ("kbuild: include Makefile.compiler only when compiler is needed")
> Cc: stable@vger.kernel.org # v5.13+
> Reported-by: "kernelci.org bot" <bot@kernelci.org>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
> Hi,
>
> This is a version of commit 4fe4a6374c4d for 6.1-stable and before,
> resolving a conflict due to a change in how $(CHECKFLAGS) is set.
>
> No functional change, just a mechanical update. Please apply.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-09-17 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 15:19 [PATCH] MIPS: Only fiddle with CHECKFLAGS if `need-compiler' Maciej W. Rozycki
2023-09-17 7:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023091744-blank-bulge-01bf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=macro@orcam.me.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox