From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79AABCE79CF for ; Wed, 20 Sep 2023 12:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236211AbjITMqJ (ORCPT ); Wed, 20 Sep 2023 08:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236336AbjITMqI (ORCPT ); Wed, 20 Sep 2023 08:46:08 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60DAD83 for ; Wed, 20 Sep 2023 05:46:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84DB4C433C7; Wed, 20 Sep 2023 12:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695213961; bh=gb/9KbYFJda2RGS9+9OmK+OUO4aRO61jO+0M6J5s4xE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x308yKWLmrITKYwEUOmsszaIMMXOdYXPU47miTTG3ySPX5U7iUBaeqMCG6VPEEpvw 411XRNmWb96Dh8QNTeZ8hyjThCz5JV9m9IfdmBmWUtjwKLmMzaVX0es2tgF/d5s//x BHTD0ndPL0QsHy+2RDj2I52/Bvn2aOLegwlUvLxA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hao Luo , Andrii Nakryiko , Sasha Levin Subject: [PATCH 5.15 026/110] libbpf: Free btf_vmlinux when closing bpf_object Date: Wed, 20 Sep 2023 13:31:24 +0200 Message-ID: <20230920112831.374505602@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230920112830.377666128@linuxfoundation.org> References: <20230920112830.377666128@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hao Luo [ Upstream commit 29d67fdebc42af6466d1909c60fdd1ef4f3e5240 ] I hit a memory leak when testing bpf_program__set_attach_target(). Basically, set_attach_target() may allocate btf_vmlinux, for example, when setting attach target for bpf_iter programs. But btf_vmlinux is freed only in bpf_object_load(), which means if we only open bpf object but not load it, setting attach target may leak btf_vmlinux. So let's free btf_vmlinux in bpf_object__close() anyway. Signed-off-by: Hao Luo Signed-off-by: Andrii Nakryiko Link: https://lore.kernel.org/bpf/20230822193840.1509809-1-haoluo@google.com Signed-off-by: Sasha Levin --- tools/lib/bpf/libbpf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index f87a15bbf53b3..9b8a0fe0eb1c3 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -7559,6 +7559,7 @@ void bpf_object__close(struct bpf_object *obj) bpf_object__elf_finish(obj); bpf_object__unload(obj); btf__free(obj->btf); + btf__free(obj->btf_vmlinux); btf_ext__free(obj->btf_ext); for (i = 0; i < obj->nr_maps; i++) -- 2.40.1