From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78BBCE79CF for ; Wed, 20 Sep 2023 12:02:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234963AbjITMCQ (ORCPT ); Wed, 20 Sep 2023 08:02:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235037AbjITMCM (ORCPT ); Wed, 20 Sep 2023 08:02:12 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EECFD8 for ; Wed, 20 Sep 2023 05:02:06 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A426CC433C7; Wed, 20 Sep 2023 12:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695211326; bh=BYW8HUiBF0kyh11FNsD+N4QIkPpCb+62heK35vtFuvY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=geexigheZhcU0sUyx9Cp4+lUOTZZlrzJBFMTGepH1SY8qe6g13mcajeT9Nz4nveBe iuJtPNhEM2MdDfa7SPrle91TNWEKX24deRc/nUPAaHYcmYRbm3ps97mSiV6FjTeqEZ 3eTBzpRRxwj5rAXedoW9d+10QJiJVcV2DwIye5FM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gaurav Jain , Meenakshi Aggarwal , Herbert Xu , Sasha Levin Subject: [PATCH 4.14 044/186] crypto: caam - fix unchecked return value error Date: Wed, 20 Sep 2023 13:29:07 +0200 Message-ID: <20230920112838.529221033@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230920112836.799946261@linuxfoundation.org> References: <20230920112836.799946261@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gaurav Jain [ Upstream commit e30685204711a6be40dec2622606950ccd37dafe ] error: Unchecked return value (CHECKED_RETURN) check_return: Calling sg_miter_next without checking return value fix: added check if(!sg_miter_next) Fixes: 8a2a0dd35f2e ("crypto: caam - strip input zeros from RSA input buffer") Signed-off-by: Gaurav Jain Signed-off-by: Meenakshi Aggarwal Reviewed-by: Gaurav Jain Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/caam/caampkc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c index 6f3f81bb880b5..01f9053db287b 100644 --- a/drivers/crypto/caam/caampkc.c +++ b/drivers/crypto/caam/caampkc.c @@ -194,7 +194,9 @@ static int caam_rsa_count_leading_zeros(struct scatterlist *sgl, if (len && *buff) break; - sg_miter_next(&miter); + if (!sg_miter_next(&miter)) + break; + buff = miter.addr; len = miter.length; -- 2.40.1