From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE4ACE79CE for ; Wed, 20 Sep 2023 12:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235042AbjITMDe (ORCPT ); Wed, 20 Sep 2023 08:03:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235089AbjITMDa (ORCPT ); Wed, 20 Sep 2023 08:03:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C99A6129 for ; Wed, 20 Sep 2023 05:03:19 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84CBBC433CB; Wed, 20 Sep 2023 12:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695211398; bh=FmEOzu5nXSaqytInKQcXrlc6esAnxXvbY0XLClfmHoI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0V7o3SQBSepQifozofOofhJkpd08fPS/4IKCBPx/8nz+38Uf5E0KUixD+MVaegT4A QzygiiSZQ0itdyecPRSxJxCOLfRNBPk4Wqb4DgNNdP3CSDoAZwIQW6+roLPgpOG/AF x7VjF9o9U6PfV9cBfxFLQBhb/mPwNpovFSWQAa5M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jinjie Ruan , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 052/186] net: arcnet: Do not call kfree_skb() under local_irq_disable() Date: Wed, 20 Sep 2023 13:29:15 +0200 Message-ID: <20230920112838.788494274@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230920112836.799946261@linuxfoundation.org> References: <20230920112836.799946261@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jinjie Ruan [ Upstream commit 786c96e92fb9e854cb8b0cb7399bb2fb28e15c4b ] It is not allowed to call kfree_skb() from hardware interrupt context or with hardware interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under local_irq_disable(). Compile tested only. Fixes: 05fcd31cc472 ("arcnet: add err_skb package for package status feedback") Signed-off-by: Jinjie Ruan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c index 998bc7bc7d1f0..0f02d2b3438f2 100644 --- a/drivers/net/arcnet/arcnet.c +++ b/drivers/net/arcnet/arcnet.c @@ -433,7 +433,7 @@ static void arcnet_reply_tasklet(unsigned long data) ret = sock_queue_err_skb(sk, ackskb); if (ret) - kfree_skb(ackskb); + dev_kfree_skb_irq(ackskb); local_irq_enable(); }; -- 2.40.1