From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B30CE79D0 for ; Wed, 20 Sep 2023 12:04:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235117AbjITMEF (ORCPT ); Wed, 20 Sep 2023 08:04:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235114AbjITMEE (ORCPT ); Wed, 20 Sep 2023 08:04:04 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5838ECA for ; Wed, 20 Sep 2023 05:03:57 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C771C433C7; Wed, 20 Sep 2023 12:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695211437; bh=j+x4Sm6O97bGUQAXVHdiKQvdOBRYcC5fITlQ1uop+tY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aB1aSvuvgYLeo6virwITUcAMyLmKaQK1LxIljJ2HtkUQ8hCE59MGPACPRafu0WaPI +jyGgq6EX2cGvMRqJo/+QgPd0yGa7z21WYbBRcswl9lnnE7TkH8/P8T1RRrnfZ+Oy+ m3rZ0YnEnnCNOYBPrw1Uyovtk43uUeFUbNy8+b/8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peng Fan , Andy Shevchenko , Sasha Levin Subject: [PATCH 4.14 092/186] amba: bus: fix refcount leak Date: Wed, 20 Sep 2023 13:29:55 +0200 Message-ID: <20230920112840.251540450@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230920112836.799946261@linuxfoundation.org> References: <20230920112836.799946261@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peng Fan [ Upstream commit e312cbdc11305568554a9e18a2ea5c2492c183f3 ] commit 5de1540b7bc4 ("drivers/amba: create devices from device tree") increases the refcount of of_node, but not releases it in amba_device_release, so there is refcount leak. By using of_node_put to avoid refcount leak. Fixes: 5de1540b7bc4 ("drivers/amba: create devices from device tree") Signed-off-by: Peng Fan Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20230821023928.3324283-1-peng.fan@oss.nxp.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/amba/bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 8ea401fc89968..e07d6a4d3f03a 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -344,6 +344,7 @@ static void amba_device_release(struct device *dev) { struct amba_device *d = to_amba_device(dev); + of_node_put(d->dev.of_node); if (d->res.parent) release_resource(&d->res); kfree(d); -- 2.40.1