From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E329DCE79D0 for ; Wed, 20 Sep 2023 12:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235089AbjITMEP (ORCPT ); Wed, 20 Sep 2023 08:04:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235091AbjITMEO (ORCPT ); Wed, 20 Sep 2023 08:04:14 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28EFE93 for ; Wed, 20 Sep 2023 05:04:08 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 609D2C433C8; Wed, 20 Sep 2023 12:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695211447; bh=MuM6phDaNYswCAHSIc+I/KpaYMMWNicp7bY0MPdxMGc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hemI9aruIS3H+ivPIYgU9EKnQ0DXLZuqkx3dTDWd2NB2vCqwqQbrx0PgS7hsY0pF7 MoScLMOuZzxAvXvkrDvdzF8AoXnL5Ah33Px/djc3hwoX7rXKywVAmMcHQZl8mo3pdV xYrYHcyGHhKarQ4E94xB4QCpRr0S3XjA9bPFQ5LE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ruan Jinjie , Linus Walleij , Vinod Koul , Sasha Levin Subject: [PATCH 4.14 096/186] dmaengine: ste_dma40: Add missing IRQ check in d40_probe Date: Wed, 20 Sep 2023 13:29:59 +0200 Message-ID: <20230920112840.425863996@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230920112836.799946261@linuxfoundation.org> References: <20230920112836.799946261@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: ruanjinjie [ Upstream commit c05ce6907b3d6e148b70f0bb5eafd61dcef1ddc1 ] Check for the return value of platform_get_irq(): if no interrupt is specified, it wouldn't make sense to call request_irq(). Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3") Signed-off-by: Ruan Jinjie Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20230724144108.2582917-1-ruanjinjie@huawei.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/ste_dma40.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index ee15d4fefbad2..498d9886ed9bc 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3577,6 +3577,10 @@ static int __init d40_probe(struct platform_device *pdev) spin_lock_init(&base->lcla_pool.lock); base->irq = platform_get_irq(pdev, 0); + if (base->irq < 0) { + ret = base->irq; + goto destroy_cache; + } ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base); if (ret) { -- 2.40.1