From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25450CE79D0 for ; Wed, 20 Sep 2023 12:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234541AbjITM2x (ORCPT ); Wed, 20 Sep 2023 08:28:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234774AbjITM2x (ORCPT ); Wed, 20 Sep 2023 08:28:53 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAD2092 for ; Wed, 20 Sep 2023 05:28:46 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26ADCC433C7; Wed, 20 Sep 2023 12:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695212926; bh=AZYJ5AmqwJMCZOArXVBiTxg1nBgxzPkQrbqqZ/br89A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kOhnsOPkv4f65iATV+dH03/L9GCUYYZj2zaaRSGlwdrGHa3toGb00WhYWCNSr9cfs hFwGLNZ4lgKuaWMBEcVWMpT6wFrWlWR4VGlAbidzjm+rDekY/lLJnH1AXY9tasjlHk 56DoBiCo8j+y6WKSGD6x/R+XfQiu5IJGnPHSXm48= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gaurav Jain , Meenakshi Aggarwal , Herbert Xu , Sasha Levin Subject: [PATCH 5.4 070/367] crypto: caam - fix unchecked return value error Date: Wed, 20 Sep 2023 13:27:27 +0200 Message-ID: <20230920112900.331475153@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230920112858.471730572@linuxfoundation.org> References: <20230920112858.471730572@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gaurav Jain [ Upstream commit e30685204711a6be40dec2622606950ccd37dafe ] error: Unchecked return value (CHECKED_RETURN) check_return: Calling sg_miter_next without checking return value fix: added check if(!sg_miter_next) Fixes: 8a2a0dd35f2e ("crypto: caam - strip input zeros from RSA input buffer") Signed-off-by: Gaurav Jain Signed-off-by: Meenakshi Aggarwal Reviewed-by: Gaurav Jain Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/caam/caampkc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c index 30e3f41ed8721..e0bba20c13cb5 100644 --- a/drivers/crypto/caam/caampkc.c +++ b/drivers/crypto/caam/caampkc.c @@ -225,7 +225,9 @@ static int caam_rsa_count_leading_zeros(struct scatterlist *sgl, if (len && *buff) break; - sg_miter_next(&miter); + if (!sg_miter_next(&miter)) + break; + buff = miter.addr; len = miter.length; -- 2.40.1