public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Stephen Zhang <starzhangzsd@gmail.com>,
	stable@vger.kernel.org, Shida Zhang <zhangshida@kylinos.cn>,
	stable@kernel.org, Andreas Dilger <adilger@dilger.ca>,
	"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [PATCH] ext4: fix rec_len verify error
Date: Sat, 23 Sep 2023 18:10:15 +0200	[thread overview]
Message-ID: <2023092314-cartel-percolate-eee7@gregkh> (raw)
In-Reply-To: <ZQ76gdIz80G8Svt-@mit.edu>

On Sat, Sep 23, 2023 at 10:47:29AM -0400, Theodore Ts'o wrote:
> On Sat, Sep 23, 2023 at 05:41:19PM +0800, Stephen Zhang wrote:
> > Apologies for this confusion. It appears that the '--subject-prefix' option
> > of the 'git send-email' command does not work with the local patch file.
> 
> Stephen,
> 
> The --subject-prefix option applies to "git format-patch" when the
> local patch file is generated, as opposed to "git send-email".  So my
> general workflow is to run "rm -rf /tmp/p ; git format-patch -o /tmp/p
> ..."  and then examine the files in /tmp/p, and then if they look
> good, run "git send-email /tmp/p/*".
> 
> I suspect it will be easier for Greg if you were to simply regenerate
> the patches with the proper subject prefix, and then resend them,
> since he has automation tools that can handle parsing the subject
> line, which scripts can do much more easily than to disentangling the
> "In-Reply-To" header to identify e-mail chains, and then parsing
> human/natural language to figure out which git tree the patches should
> be applied to.  :-)

Just a hint, I can usually NOT see the In-Reply-To headers at all, as
the email it was in response to is long gone from my system.

Which is why, the description of how to fix up a patch for the stable
tree that has failed to apply there, tells you how to do this in a way
that will show the proper version number.

If only anyone would actually read the emails we sent with the helpful
text, here's one example for a DRM patch that failed to apply:

	To reproduce the conflict and resubmit, you may use the following commands:

	git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y
	git checkout FETCH_HEAD
	git cherry-pick -x ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a
	# <resolve conflicts, build, test, etc.>
	git commit -s
	git send-email --to '<stable@vger.kernel.org>' --in-reply-to '2023092029-banter-truth-cf72@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^..

thanks,

greg k-h

  reply	other threads:[~2023-09-23 16:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  9:58 FAILED: patch "[PATCH] ext4: fix rec_len verify error" failed to apply to 4.19-stable tree gregkh
2023-09-22  2:54 ` [PATCH] ext4: fix rec_len verify error zhangshida
2023-09-22  9:27   ` Greg KH
2023-09-23  9:41     ` Stephen Zhang
2023-09-23 14:47       ` Theodore Ts'o
2023-09-23 16:10         ` Greg KH [this message]
2023-09-24  2:27 ` [PATCH 4.19.y] " zhangshida
2023-09-24  2:58   ` Stephen Zhang
2023-09-24  2:58 ` zhangshida
  -- strict thread matches above, loose matches on Subject: below --
2023-09-20  9:58 FAILED: patch "[PATCH] ext4: fix rec_len verify error" failed to apply to 4.14-stable tree gregkh
2023-09-22  5:39 ` [PATCH] ext4: fix rec_len verify error zhangshida
2023-09-22  9:23   ` Greg KH
2023-09-22 15:11     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023092314-cartel-percolate-eee7@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=adilger@dilger.ca \
    --cc=djwong@kernel.org \
    --cc=stable@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=starzhangzsd@gmail.com \
    --cc=tytso@mit.edu \
    --cc=zhangshida@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox