public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Rohr <prohr@google.com>
To: stable@vger.kernel.org
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
	"Maciej Żenczykowski" <maze@google.com>,
	"Lorenzo Colitti" <lorenzo@google.com>,
	"Patrick Rohr" <prohr@google.com>,
	"David Ahern" <dsahern@kernel.org>,
	"Simon Horman" <horms@kernel.org>,
	"Leon Romanovsky" <leonro@nvidia.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: [PATCH 6.1 3/3] net: release reference to inet6_dev pointer
Date: Mon, 25 Sep 2023 14:10:34 -0700	[thread overview]
Message-ID: <20230925211034.905320-4-prohr@google.com> (raw)
In-Reply-To: <20230925211034.905320-1-prohr@google.com>

addrconf_prefix_rcv returned early without releasing the inet6_dev
pointer when the PIO lifetime is less than accept_ra_min_lft.

Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")
Cc: Maciej Żenczykowski <maze@google.com>
Cc: Lorenzo Colitti <lorenzo@google.com>
Cc: David Ahern <dsahern@kernel.org>
Cc: Simon Horman <horms@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Patrick Rohr <prohr@google.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/ipv6/addrconf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 53db8daa7385..96f4351b55a6 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2734,7 +2734,7 @@ void addrconf_prefix_rcv(struct net_device *dev, u8 *opt, int len, bool sllao)
 	}
 
 	if (valid_lft != 0 && valid_lft < in6_dev->cnf.accept_ra_min_lft)
-		return;
+		goto put;
 
 	/*
 	 *	Two things going on here:
-- 
2.42.0.515.g380fc7ccd1-goog


  parent reply	other threads:[~2023-09-25 21:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 21:10 [PATCH 6.1 0/3] net: add sysctl accept_ra_min_lft Patrick Rohr
2023-09-25 21:10 ` [PATCH 6.1 1/3] net: add sysctl accept_ra_min_rtr_lft Patrick Rohr
2023-09-25 21:10 ` [PATCH 6.1 2/3] net: change accept_ra_min_rtr_lft to affect all RA lifetimes Patrick Rohr
2023-09-25 21:10 ` Patrick Rohr [this message]
2023-10-05 21:37 ` [PATCH 6.1 0/3] net: add sysctl accept_ra_min_lft Patrick Rohr
2023-10-06  5:52   ` Greg KH
2023-10-06  6:21     ` Greg KH
2023-10-06  7:06       ` Maciej Żenczykowski
2023-10-06  7:53         ` Greg KH
2023-10-06 12:17         ` Sasha Levin
2023-10-06 19:40           ` Maciej Żenczykowski
2023-10-07  9:30             ` Greg KH
2023-10-07  9:48               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230925211034.905320-4-prohr@google.com \
    --to=prohr@google.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=horms@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=lorenzo@google.com \
    --cc=maze@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox