From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6434EE7C4E8 for ; Wed, 4 Oct 2023 18:10:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243904AbjJDSKC (ORCPT ); Wed, 4 Oct 2023 14:10:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243902AbjJDSKB (ORCPT ); Wed, 4 Oct 2023 14:10:01 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B0DBF for ; Wed, 4 Oct 2023 11:09:58 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88D1EC433CB; Wed, 4 Oct 2023 18:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696442997; bh=7xPxOdtwW4a5GPUXT4gswuHz+WyEVZkUlW9Jq6lLpXg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iBSlw7EUcChLOzCiczmuhq/0H5IHU9LKdgLQtJJDJSnpcpurN7tliFsxgNzrzS+YE B+9/f8qfhc95l/U9jMXbMYlh3/un7kgoFQERH2YTaPZpyEdR76q64oFZW53CKmJLth 4Q8M/wCnFYZ/QRmPJEuQaWRca6ZpFLV2p59ut6H8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vishal Goel , Casey Schaufler , Sasha Levin Subject: [PATCH 5.15 156/183] Smack:- Use overlay inode label in smack_inode_copy_up() Date: Wed, 4 Oct 2023 19:56:27 +0200 Message-ID: <20231004175210.558577723@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231004175203.943277832@linuxfoundation.org> References: <20231004175203.943277832@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Vishal Goel [ Upstream commit 387ef964460f14fe1c1ea29aba70e22731ea7cf7 ] Currently in "smack_inode_copy_up()" function, process label is changed with the label on parent inode. Due to which, process is assigned directory label and whatever file or directory created by the process are also getting directory label which is wrong label. Changes has been done to use label of overlay inode instead of parent inode. Signed-off-by: Vishal Goel Signed-off-by: Casey Schaufler Signed-off-by: Sasha Levin --- security/smack/smack_lsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index f8c40c49d860c..39f564f47fea5 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c @@ -4663,7 +4663,7 @@ static int smack_inode_copy_up(struct dentry *dentry, struct cred **new) /* * Get label from overlay inode and set it in create_sid */ - isp = smack_inode(d_inode(dentry->d_parent)); + isp = smack_inode(d_inode(dentry)); skp = isp->smk_inode; tsp->smk_task = skp; *new = new_creds; -- 2.40.1