From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D622E7C4EC for ; Wed, 4 Oct 2023 18:34:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244408AbjJDSey (ORCPT ); Wed, 4 Oct 2023 14:34:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243808AbjJDSex (ORCPT ); Wed, 4 Oct 2023 14:34:53 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51831AB for ; Wed, 4 Oct 2023 11:34:50 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93D02C433C7; Wed, 4 Oct 2023 18:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696444490; bh=I0wf1u+VDpu1NHdo4aZGIx71fTcTzkie8TXmW5N4BwE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nkKTSgZYTaSNzRItG5sAjnlmkSMwumJAk6/3xexQvt30/NHO5B/TNEMV3xPso238R wGt2ThQ+VULLsUglrHSHM3e+GG2/tvPkdtWv1kiH+QE3bCmbkuhVxbfe6mvBI8Aj+N 9JmBFdqa/xY7bLQ7l6zxAsi0k0tesLILj3KuxZz8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Leonard , Jens Axboe Subject: [PATCH 6.5 268/321] io_uring/fs: remove sqe->rw_flags checking from LINKAT Date: Wed, 4 Oct 2023 19:56:53 +0200 Message-ID: <20231004175241.696860128@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231004175229.211487444@linuxfoundation.org> References: <20231004175229.211487444@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 6.5-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jens Axboe commit a52d4f657568d6458e873f74a9602e022afe666f upstream. This is unionized with the actual link flags, so they can of course be set and they will be evaluated further down. If not we fail any LINKAT that has to set option flags. Fixes: cf30da90bc3a ("io_uring: add support for IORING_OP_LINKAT") Cc: stable@vger.kernel.org Reported-by: Thomas Leonard Link: https://github.com/axboe/liburing/issues/955 Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- io_uring/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/io_uring/fs.c +++ b/io_uring/fs.c @@ -243,7 +243,7 @@ int io_linkat_prep(struct io_kiocb *req, struct io_link *lnk = io_kiocb_to_cmd(req, struct io_link); const char __user *oldf, *newf; - if (sqe->rw_flags || sqe->buf_index || sqe->splice_fd_in) + if (sqe->buf_index || sqe->splice_fd_in) return -EINVAL; if (unlikely(req->flags & REQ_F_FIXED_FILE)) return -EBADF;