From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9168E95A60 for ; Sat, 7 Oct 2023 11:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234166AbjJGLYm (ORCPT ); Sat, 7 Oct 2023 07:24:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234087AbjJGLYl (ORCPT ); Sat, 7 Oct 2023 07:24:41 -0400 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73664B9 for ; Sat, 7 Oct 2023 04:24:40 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 3FECF3200999; Sat, 7 Oct 2023 07:24:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sat, 07 Oct 2023 07:24:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1696677875; x=1696764275; bh=QV t/3v9LjowRKy98MrMKYBNEyAEJnitE9we2PnKUIHM=; b=Ko2Ea3/qJkFWpqFibS p/0nm0hVG7FH5Rq6wHlsG3GcZlmENHsyd5euBV4tbc1MdEMLTsQX0I/vt10PM4AT JmFPKen/IRkGs4MLpmhp1Tum1Y18l3DQhcDKeBnWjZ++mxu4rh1leBwoCNyNeEsa 8nxNwN2uxN9F26L35wrlclYAhfjpFDjgcKQr3ZqjSt38qUN1yksHrZb6/xkGRIeU 000Qwex6PCc1qRGxRxaW33ewaBv6w8DPzGNKYuB4o7suVd8yopg8KNzA/JGRCBWP e+CIaNJEekpdkyhdRmSt2KNitx9cTDOkDBRqcawhcKJZy1CdKvPLu+OLO53pj3pA XBQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1696677875; x=1696764275; bh=QVt/3v9LjowRK y98MrMKYBNEyAEJnitE9we2PnKUIHM=; b=a2W0nVTlsE5H0y2fFB5X8gYAu+raZ U7vkYaJmbiQc23/fuybamJF0YF0+Kd0mdfzhsuwkUjgtHzfRSg0An+yimkfRCWRp oskqRPl/thJacH1BisHmw/gdkl3Ua0nykp5CDawaMdQDwOwjq39tFKEERFeGKOb5 J8XrOUxuNZS+DTlo/6wTxp0ylxsHAReUsX4uuCQNzA/Sq5+h1zul1QnrD1Ytgr60 zfg4VBMliMp2QUbsJwe8cV4kbx6yc2kTP48xkWlbwaIkEZqMHXcqsBDD4vnqfFdn B0U5QGmKtuowMeYqxiNTDijxPTxxrSWxY+F+/2jIEtAEM2tpWdjwBeHdQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrgeelgdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeegheeuhe fgtdeluddtleekfeegjeetgeeikeehfeduieffvddufeefleevtddtvdenucffohhmrghi nhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Oct 2023 07:24:35 -0400 (EDT) Date: Sat, 7 Oct 2023 13:24:32 +0200 From: Greg KH To: Shaoying Xu Cc: stable@vger.kernel.org, markovicbudimir@gmail.com, Jamal Hadi Salim , Jakub Kicinski Subject: Re: [PATCH 4.14] net/sched: sch_hfsc: Ensure inner classes have fsc curve Message-ID: <2023100716-hacksaw-pampers-22f1@gregkh> References: <20230920175145.23384-1-shaoyi@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920175145.23384-1-shaoyi@amazon.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Sep 20, 2023 at 05:51:45PM +0000, Shaoying Xu wrote: > From: Budimir Markovic > > [ Upstream commit b3d26c5702c7d6c45456326e56d2ccf3f103e60f ] > > HFSC assumes that inner classes have an fsc curve, but it is currently > possible for classes without an fsc curve to become parents. This leads > to bugs including a use-after-free. > > Don't allow non-root classes without HFSC_FSC to become parents. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Reported-by: Budimir Markovic > Signed-off-by: Budimir Markovic > Acked-by: Jamal Hadi Salim > Link: https://lore.kernel.org/r/20230824084905.422-1-markovicbudimir@gmail.com > Signed-off-by: Jakub Kicinski > [ v4.14: Delete NL_SET_ERR_MSG because extack is not added to hfsc_change_class ] > Cc: # 4.14 Trailing whitespace, please fix your editor :( Anyway, now queued up, thanks. greg k-h