From: Greg KH <greg@kroah.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: stable@vger.kernel.org, Wayne Lin <wayne.lin@amd.com>,
Chao-kai Wang <stylon.wang@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Daniel Wheeler <daniel.wheeler@amd.com>
Subject: Re: [PATCH 6.1] drm/amd/display: Adjust the MST resume flow
Date: Sat, 7 Oct 2023 11:51:57 +0200 [thread overview]
Message-ID: <2023100751-vastly-crust-d17c@gregkh> (raw)
In-Reply-To: <20230920153331.73662-1-mario.limonciello@amd.com>
On Wed, Sep 20, 2023 at 10:33:31AM -0500, Mario Limonciello wrote:
> From: Wayne Lin <wayne.lin@amd.com>
>
> [Why]
> In drm_dp_mst_topology_mgr_resume() today, it will resume the
> mst branch to be ready handling mst mode and also consecutively do
> the mst topology probing. Which will cause the dirver have chance
> to fire hotplug event before restoring the old state. Then Userspace
> will react to the hotplug event based on a wrong state.
>
> [How]
> Adjust the mst resume flow as:
> 1. set dpcd to resume mst branch status
> 2. restore source old state
> 3. Do mst resume topology probing
>
> For drm_dp_mst_topology_mgr_resume(), it's better to adjust it to
> pull out topology probing work into a 2nd part procedure of the mst
> resume. Will have a follow up patch in drm.
>
> Reviewed-by: Chao-kai Wang <stylon.wang@amd.com>
> Cc: Mario Limonciello <mario.limonciello@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
> Acked-by: Stylon Wang <stylon.wang@amd.com>
> Signed-off-by: Wayne Lin <wayne.lin@amd.com>
> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> (cherry picked from commit ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a)
> Adjust for missing variable rename in
> f0127cb11299 ("drm/amdgpu/display/mst: adjust the naming of mst_port and port of aconnector")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> This is a follow up for https://lore.kernel.org/stable/2023092029-banter-truth-cf72@gregkh/
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 93 ++++++++++++++++---
> 1 file changed, 80 insertions(+), 13 deletions(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-10-07 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 15:33 [PATCH 6.1] drm/amd/display: Adjust the MST resume flow Mario Limonciello
2023-10-07 9:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100751-vastly-crust-d17c@gregkh \
--to=greg@kroah.com \
--cc=alexander.deucher@amd.com \
--cc=daniel.wheeler@amd.com \
--cc=mario.limonciello@amd.com \
--cc=stable@vger.kernel.org \
--cc=stylon.wang@amd.com \
--cc=wayne.lin@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox