From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BFF5E95A61 for ; Sat, 7 Oct 2023 09:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234176AbjJGJwI (ORCPT ); Sat, 7 Oct 2023 05:52:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234148AbjJGJwH (ORCPT ); Sat, 7 Oct 2023 05:52:07 -0400 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E2FFB9 for ; Sat, 7 Oct 2023 02:52:06 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2864B32009BC; Sat, 7 Oct 2023 05:52:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 07 Oct 2023 05:52:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1696672321; x=1696758721; bh=PI /FYbXP4tamTEEOaZ71Eser6r+FAUef7sdQARGl9f4=; b=ZArjl1HUy8VDHPRgqO gQ+SSOeRuvdkOi/QUukXTJJ5P107t/x/dA7/7/hZuB2xhZ5rBoVQB+O/+Sapf1+u tZI99jkRj8fWKSFHwzg6NOuWAB/jzBC0af+Z3bu+LmeGftME+2HiKtvdvjboJJlm mTUizZzVx6tSPeb+piW1Nt6Q/d2BxyTmlVnEGsghv+MsoAWWJ0qCDv/OEQVYSGVW 0/c9jgmLE0OnuqwCkx6GW30qsVT2fb3aIW+04BR9MP5JV6gcXBKTY4V1eIElqZSp 70stptTxWYImNDBGhCIXFDbdkynRYX1VENsX98b+BUWCBo8Rr/fQG8UW+dEiubqb h+lQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1696672321; x=1696758721; bh=PI/FYbXP4tamT EEOaZ71Eser6r+FAUef7sdQARGl9f4=; b=i+BJ/L9Zvs3U5/NBG/9rumVrYWNPf X/qYqMo5MNy5X9CxZEebg1blBv3dQrKHpCfg/f+c/oOhmAB01xTxcgTRJIR9484C /Nsw7URRc/aDKhs28bdCH0Wlj48t1Op6mgaTxc/dyjkOL8r03tm6E510ILKJrA2M s+tVBWGmhUlQxQCyC5KY8flEy+HnXvwWvT0tTGr5adE9mBSCIVcDEPr6EAaeR0gL a6GKDbaAnA6EsCYYKtAj2pOTSCNVju5KdkwB7myY1ChWf3LMcTWbi4lJXmjwK8Zl o+k7e8Y8gM+f7C4If54acY4xRjR7boC8SGZvBuHd6MBpGtYiaLmg0sLTw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrgeelgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeegheeuhe fgtdeluddtleekfeegjeetgeeikeehfeduieffvddufeefleevtddtvdenucffohhmrghi nhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Oct 2023 05:52:00 -0400 (EDT) Date: Sat, 7 Oct 2023 11:51:57 +0200 From: Greg KH To: Mario Limonciello Cc: stable@vger.kernel.org, Wayne Lin , Chao-kai Wang , Alex Deucher , Daniel Wheeler Subject: Re: [PATCH 6.1] drm/amd/display: Adjust the MST resume flow Message-ID: <2023100751-vastly-crust-d17c@gregkh> References: <20230920153331.73662-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920153331.73662-1-mario.limonciello@amd.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Sep 20, 2023 at 10:33:31AM -0500, Mario Limonciello wrote: > From: Wayne Lin > > [Why] > In drm_dp_mst_topology_mgr_resume() today, it will resume the > mst branch to be ready handling mst mode and also consecutively do > the mst topology probing. Which will cause the dirver have chance > to fire hotplug event before restoring the old state. Then Userspace > will react to the hotplug event based on a wrong state. > > [How] > Adjust the mst resume flow as: > 1. set dpcd to resume mst branch status > 2. restore source old state > 3. Do mst resume topology probing > > For drm_dp_mst_topology_mgr_resume(), it's better to adjust it to > pull out topology probing work into a 2nd part procedure of the mst > resume. Will have a follow up patch in drm. > > Reviewed-by: Chao-kai Wang > Cc: Mario Limonciello > Cc: Alex Deucher > Cc: stable@vger.kernel.org > Acked-by: Stylon Wang > Signed-off-by: Wayne Lin > Tested-by: Daniel Wheeler > Signed-off-by: Alex Deucher > (cherry picked from commit ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a) > Adjust for missing variable rename in > f0127cb11299 ("drm/amdgpu/display/mst: adjust the naming of mst_port and port of aconnector") > Signed-off-by: Mario Limonciello > --- > This is a follow up for https://lore.kernel.org/stable/2023092029-banter-truth-cf72@gregkh/ > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 93 ++++++++++++++++--- > 1 file changed, 80 insertions(+), 13 deletions(-) Now queued up, thanks. greg k-h