From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91250E95A91 for ; Mon, 9 Oct 2023 13:12:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376790AbjJINMs (ORCPT ); Mon, 9 Oct 2023 09:12:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376923AbjJINMh (ORCPT ); Mon, 9 Oct 2023 09:12:37 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01378181 for ; Mon, 9 Oct 2023 06:11:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51FEEC433CA; Mon, 9 Oct 2023 13:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696857086; bh=XyJ0H08b1dWwIi5Lp3Aeif7zeOyOa7F5ZkZEA2lBAHg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QFEOvuK8a1dZR6vQku5EbuvpI7wokgtf4iKTT0UIzuGAYvR33PIJNj65mVmQqXk09 qcvsGa0d+qvRSASP9B+Pesp4IRrJwisBkp72GUNpFk9jL0CYwnbWE0Q0m2VeyBxnAe vEtJe6s8Bu3wiJbQuP98vGYXVZHXdSggkvlG4eP8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daniel Bristot de Oliveira , Sasha Levin Subject: [PATCH 6.5 065/163] rtla/timerlat_aa: Zero thread sum after every sample analysis Date: Mon, 9 Oct 2023 15:00:29 +0200 Message-ID: <20231009130125.840286791@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231009130124.021290599@linuxfoundation.org> References: <20231009130124.021290599@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 6.5-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daniel Bristot de Oliveira [ Upstream commit 02d89917ef68acbe65c7cc2323f1db4429879878 ] The thread thread_thread_sum accounts for thread interference during a single activation. It was not being zeroed, so it was accumulating thread interference over all activations. It was not that visible when timerlat was the highest priority. Link: https://lore.kernel.org/lkml/97bff55b0141f2d01b47d9450a5672fde147b89a.1691162043.git.bristot@kernel.org Fixes: 27e348b221f6 ("rtla/timerlat: Add auto-analysis core") Signed-off-by: Daniel Bristot de Oliveira Signed-off-by: Sasha Levin --- tools/tracing/rtla/src/timerlat_aa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/tracing/rtla/src/timerlat_aa.c b/tools/tracing/rtla/src/timerlat_aa.c index e0ffe69c271c6..dec5b4c4511e1 100644 --- a/tools/tracing/rtla/src/timerlat_aa.c +++ b/tools/tracing/rtla/src/timerlat_aa.c @@ -159,6 +159,7 @@ static int timerlat_aa_irq_latency(struct timerlat_aa_data *taa_data, taa_data->thread_nmi_sum = 0; taa_data->thread_irq_sum = 0; taa_data->thread_softirq_sum = 0; + taa_data->thread_thread_sum = 0; taa_data->thread_blocking_duration = 0; taa_data->timer_irq_start_time = 0; taa_data->timer_irq_duration = 0; -- 2.40.1