From: Greg KH <gregkh@linuxfoundation.org>
To: poester <poester@internetbrands.com>
Cc: stable@vger.kernel.org, Phil O <kernel@linuxace.com>
Subject: Re: Linux 6.1.56
Date: Thu, 12 Oct 2023 19:49:07 +0200 [thread overview]
Message-ID: <2023101229-sash-kilogram-9a46@gregkh> (raw)
In-Reply-To: <20231012165439.137237-2-kernel@linuxace.com>
On Thu, Oct 12, 2023 at 09:54:40AM -0700, poester wrote:
> Since rolling out 6.1.56 we have been experiencing file corruption
> over NFSv3. We bisected it down to
>
> f16fd0b11f0f NFS: Fix error handling for O_DIRECT write scheduling
>
> But that doesn't cleanly revert so we ended up reverting all NFS
> changes from 6.1.56 and the corruption no longer occurs. Namely:
>
> edd1f0614510 NFS: More fixes for nfs_direct_write_reschedule_io()
> d4729af1c73c NFS: Use the correct commit info in nfs_join_page_group()
> 1f49386d6779 NFS: More O_DIRECT accounting fixes for error paths
> 4d98038e5bd9 NFS: Fix O_DIRECT locking issues
> f16fd0b11f0f NFS: Fix error handling for O_DIRECT write scheduling
>
> The test case is fairly easily reproduced for us:
>
> dd if=testfile of=testfile2 oflag=direct; md5sum testfile*
>
> shows a different md5sum between the two files on 6.1.56+ kernels.
> Interestingly, on 6.5.7 this problem does not occur even though it
> contains the same O_DIRECT patch as f16fd0b11f0f.
>
> We opened a bugzilla on this:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=217999
>
> But this seems like a critical issue to us which should likely be
> addressed in 6.1.58.
I don't touch bugzilla, but I'll go revert these now and push out a -rc
release with the reverts as you aren't the only one who has reported
this and it would be good to get it resolved.
thanks!
greg k-h
prev parent reply other threads:[~2023-10-12 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 12:59 Linux 6.1.56 Greg Kroah-Hartman
2023-10-06 12:59 ` Greg Kroah-Hartman
2023-10-12 16:54 ` poester
2023-10-12 17:49 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101229-sash-kilogram-9a46@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=kernel@linuxace.com \
--cc=poester@internetbrands.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox