From: Patrick Rohr <prohr@google.com>
To: stable@vger.kernel.org
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
"Sasha Levin" <sashal@kernel.org>,
"Maciej Żenczykowski" <maze@google.com>,
"Lorenzo Colitti" <lorenzo@google.com>,
"Patrick Rohr" <prohr@google.com>,
"David Ahern" <dsahern@kernel.org>,
"Simon Horman" <horms@kernel.org>,
"Leon Romanovsky" <leonro@nvidia.com>,
"David S . Miller" <davem@davemloft.net>
Subject: [PATCH 5.10 3/3] net: release reference to inet6_dev pointer
Date: Fri, 13 Oct 2023 14:44:14 -0700 [thread overview]
Message-ID: <20231013214414.3482322-4-prohr@google.com> (raw)
In-Reply-To: <20231013214414.3482322-1-prohr@google.com>
commit 5cb249686e67dbef3ffe53887fa725eefc5a7144 upstream.
addrconf_prefix_rcv returned early without releasing the inet6_dev
pointer when the PIO lifetime is less than accept_ra_min_lft.
Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")
Cc: Maciej Żenczykowski <maze@google.com>
Cc: Lorenzo Colitti <lorenzo@google.com>
Cc: David Ahern <dsahern@kernel.org>
Cc: Simon Horman <horms@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Patrick Rohr <prohr@google.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/ipv6/addrconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 2a389895d0a2..193e5f275733 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2727,7 +2727,7 @@ void addrconf_prefix_rcv(struct net_device *dev, u8 *opt, int len, bool sllao)
}
if (valid_lft != 0 && valid_lft < in6_dev->cnf.accept_ra_min_lft)
- return;
+ goto put;
/*
* Two things going on here:
--
2.42.0.655.g421f12c284-goog
next prev parent reply other threads:[~2023-10-13 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 21:44 [PATCH 5.10 0/3] net: add sysctl accept_ra_min_lft Patrick Rohr
2023-10-13 21:44 ` [PATCH 5.10 1/3] net: add sysctl accept_ra_min_rtr_lft Patrick Rohr
2023-10-13 21:44 ` [PATCH 5.10 2/3] net: change accept_ra_min_rtr_lft to affect all RA lifetimes Patrick Rohr
2023-10-13 21:44 ` Patrick Rohr [this message]
2023-10-15 17:46 ` [PATCH 5.10 0/3] net: add sysctl accept_ra_min_lft Greg KH
2023-10-15 17:59 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013214414.3482322-4-prohr@google.com \
--to=prohr@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=leonro@nvidia.com \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox