From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FC0CDB482 for ; Mon, 16 Oct 2023 09:04:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233209AbjJPJEY (ORCPT ); Mon, 16 Oct 2023 05:04:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233291AbjJPJEW (ORCPT ); Mon, 16 Oct 2023 05:04:22 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DAE5E8 for ; Mon, 16 Oct 2023 02:04:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E599C433CA; Mon, 16 Oct 2023 09:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697447060; bh=C4fWrygokFTgACE3bkVZ+so8ShlcpIhlpPFjJlmvx1o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gBSzy6h4967p0dK5L37nGzEVSrcBM0/rNu0p6l22FDmxbDiBeUCTWz10gHUdwLEga 3zJKDSzpB4vgMBt1WCrkrRosR2ea6cZ7womiXRA1FgwOhDfswP15ScANT0L/Uyv4AT V9PdS8d/VECxHPVd1+vCBfUw6FJwVz+jPum/Xppo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peter Wang , Bart Van Assche , Stanley Chu , "Martin K. Petersen" Subject: [PATCH 6.1 118/131] scsi: ufs: core: Correct clear TM error log Date: Mon, 16 Oct 2023 10:41:41 +0200 Message-ID: <20231016084002.998556905@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231016084000.050926073@linuxfoundation.org> References: <20231016084000.050926073@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Wang commit a20c4350c6a12405b7f732b3ee6801ffe2cc45ce upstream. The clear TM function error log status was inverted. Fixes: 4693fad7d6d4 ("scsi: ufs: core: Log error handler activity") Signed-off-by: Peter Wang Link: https://lore.kernel.org/r/20231003022002.25578-1-peter.wang@mediatek.com Reviewed-by: Bart Van Assche Reviewed-by: Stanley Chu Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/ufs/core/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -6749,7 +6749,7 @@ static int ufshcd_clear_tm_cmd(struct uf mask, 0, 1000, 1000); dev_err(hba->dev, "Clearing task management function with tag %d %s\n", - tag, err ? "succeeded" : "failed"); + tag, err < 0 ? "failed" : "succeeded"); out: return err;