From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Kanchan Joshi <joshiiitr@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Kanchan Joshi <joshi.k@samsung.com>,
axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, vincentfu@gmail.com,
ankit.kumar@samsung.com, stable@vger.kernel.org,
Vincent Fu <vincent.fu@samsung.com>
Subject: Re: [PATCH v4] nvme: fix corruption for passthrough meta/data
Date: Mon, 16 Oct 2023 20:34:38 +0200 [thread overview]
Message-ID: <20231016183438.GA15911@lst.de> (raw)
In-Reply-To: <ZS2BA_Oj4kcwRbiY@kbusch-mbp.dhcp.thefacebook.com>
On Mon, Oct 16, 2023 at 12:29:23PM -0600, Keith Busch wrote:
> It sounds like the kernel memory is the only reason for the concern, and
> you don't really care if we're corrupting user memory. If so, let's just
> use that instead of kernel bounce buffers. (Minor digression, the
> current bounce 'buf' is leaking kernel memory on reads since it doesn't
> zero it).
No, arbitrary memory overwrite is always an issue, userspace or kernel,
data or metadata buffer.
Note that even without block layer bounce buffering, there can always
be other kernel memory involved, e.g. swiotlb.
We need to get the fix to disable the unprivileged passthrough in ASAP.
next prev parent reply other threads:[~2023-10-16 18:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231013052157epcas5p3dc0698c56f9846191d315fa8d33ccb5c@epcas5p3.samsung.com>
2023-10-13 5:14 ` [PATCH v4] nvme: fix corruption for passthrough meta/data Kanchan Joshi
2023-10-13 5:26 ` Christoph Hellwig
2023-10-13 5:37 ` Kanchan Joshi
2023-10-13 10:14 ` Kanchan Joshi
2023-10-13 12:59 ` Kanchan Joshi
2023-10-13 13:54 ` Keith Busch
2023-10-13 15:11 ` Kanchan Joshi
2023-10-13 15:47 ` Christoph Hellwig
2023-10-13 18:35 ` Kanchan Joshi
2023-10-16 18:29 ` Keith Busch
2023-10-16 18:34 ` Christoph Hellwig [this message]
2023-10-15 19:19 ` Kanchan Joshi
2023-10-16 5:46 ` Christoph Hellwig
2023-10-26 14:33 ` Kanchan Joshi
2023-10-26 15:08 ` Keith Busch
2023-10-27 7:09 ` Kanchan Joshi
2023-10-13 5:32 ` Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016183438.GA15911@lst.de \
--to=hch@lst.de \
--cc=ankit.kumar@samsung.com \
--cc=axboe@kernel.dk \
--cc=joshi.k@samsung.com \
--cc=joshiiitr@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=vincent.fu@samsung.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox