From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60725CDB465 for ; Thu, 19 Oct 2023 05:04:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbjJSFER (ORCPT ); Thu, 19 Oct 2023 01:04:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232076AbjJSFEQ (ORCPT ); Thu, 19 Oct 2023 01:04:16 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A1B910F for ; Wed, 18 Oct 2023 22:04:15 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 8758C67373; Thu, 19 Oct 2023 07:04:11 +0200 (CEST) Date: Thu, 19 Oct 2023 07:04:11 +0200 From: Christoph Hellwig To: Keith Busch Cc: Kanchan Joshi , hch@lst.de, axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org, gost.dev@samsung.com, vincentfu@gmail.com, stable@vger.kernel.org Subject: Re: [PATCH v2] nvme: remove unprivileged passthrough support Message-ID: <20231019050411.GA14044@lst.de> References: <20231016060519.231880-1-joshi.k@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Oct 18, 2023 at 03:26:20PM -0600, Keith Busch wrote: > On further consideration and some offline chats, I believe this large > change is a bit too late for 6.6. I think this should wait for 6.7 (and > stable), hopefully preserving non-root access in some sane capacity. > It's backed out now, and current nvme-6.6 PR does not include this > patch. Umm, what are the offlist discussions? We leave an exploitable hole in, so I don't think waiting any longer is an option.