stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Backport commit 786dee864804 ("mm/memory_hotplug: rate limit page migration warnings")
@ 2023-10-20 14:01 pjy
  2023-10-20 14:26 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: pjy @ 2023-10-20 14:01 UTC (permalink / raw)
  To: stable; +Cc: lmark


Please backport commit 786dee864804 ("mm/memory_hotplug: ratelimit page
migration warnings") to 5.10 stable branch.

Commit message:
"""
When offlining memory the system can attempt to migrate a lot of pages, if
there are problems with migration this can flood the logs.  Printing all
the data hogs the CPU and cause some RT threads to run for a long time,
which may have some bad consequences.

Rate limit the page migration warnings in order to avoid this.
"""

We are sometimes seeing RCU stalls while offlining memory with the 5.10
kernel due to the printing of these messages.

Applying this patch solves the problem by ratelimiting the prints.

Thanks,
Puranjay

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Backport commit 786dee864804 ("mm/memory_hotplug: rate limit page migration warnings")
  2023-10-20 14:01 Backport commit 786dee864804 ("mm/memory_hotplug: rate limit page migration warnings") pjy
@ 2023-10-20 14:26 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2023-10-20 14:26 UTC (permalink / raw)
  To: pjy; +Cc: stable, lmark

On Fri, Oct 20, 2023 at 02:01:13PM +0000, pjy@amazon.com wrote:
> 
> Please backport commit 786dee864804 ("mm/memory_hotplug: ratelimit page
> migration warnings") to 5.10 stable branch.
> 
> Commit message:
> """
> When offlining memory the system can attempt to migrate a lot of pages, if
> there are problems with migration this can flood the logs.  Printing all
> the data hogs the CPU and cause some RT threads to run for a long time,
> which may have some bad consequences.
> 
> Rate limit the page migration warnings in order to avoid this.
> """
> 
> We are sometimes seeing RCU stalls while offlining memory with the 5.10
> kernel due to the printing of these messages.
> 
> Applying this patch solves the problem by ratelimiting the prints.

Now queued up, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-20 14:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-20 14:01 Backport commit 786dee864804 ("mm/memory_hotplug: rate limit page migration warnings") pjy
2023-10-20 14:26 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).