From: Greg KH <gregkh@linuxfoundation.org>
To: Cameron Williams <cang1@live.co.uk>
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v4 01/11] tty: 8250: Fix IS-200 PCI ID comment
Date: Sat, 21 Oct 2023 18:19:34 +0200 [thread overview]
Message-ID: <2023102107-poser-recipient-3593@gregkh> (raw)
In-Reply-To: <DU0PR02MB78993B6AD85F6550AF6590FBC4DBA@DU0PR02MB7899.eurprd02.prod.outlook.com>
On Fri, Oct 20, 2023 at 05:03:07PM +0100, Cameron Williams wrote:
> Fix the PCI comment for the IS-200 card. The PCI ID for the IS-200
> is 0x0d80, and the definition used (PCI_DEVICE_ID_INTASHIELD_IS200)
> is indeed 0x0d80, clarify that by fixing the comment as its
> neighbouring cards are all at 0x0020 offsets.
>
> Fixes: 737c17561fb2 ("[SERIAL] Support for Intashield 2 port PCI serial card")
> Cc: stable@vger.kernel.org
> Signed-off-by: Cameron Williams <cang1@live.co.uk>
> ---
> I argue for fixing this rather than removing due to this patch series (and
> the code already in the kernel) referring to the rest of the cards in
> the manufacturer's product line by hex ID, makes sense to me to
> have the hex IDs all displayed correctly one way or another in the
> one driver as the IS-200 and 400 are the only cards to use a definition instead.
I'll take this, but it is obviously not for stable kernels to take, as
it has no code functional changes.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-21 16:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BBPatchesV4>
2023-10-20 16:03 ` [PATCH v4 00/11] tty: 8250: Brainboxes card additions/fixes Cameron Williams
[not found] ` <20231020160412.118550-1-cang1@live.co.uk>
2023-10-20 16:03 ` [PATCH v4 01/11] tty: 8250: Fix IS-200 PCI ID comment Cameron Williams
2023-10-21 16:19 ` Greg KH [this message]
2023-10-20 16:03 ` [PATCH v4 02/11] tty: 8250: Remove UC-257 and UC-431 Cameron Williams
2023-10-20 16:03 ` [PATCH v4 03/11] tty: 8250: Add support for additional Brainboxes UC cards Cameron Williams
2023-10-20 16:03 ` [PATCH v4 04/11] tty: 8250: Add support for Brainboxes UP cards Cameron Williams
2023-10-20 16:03 ` [PATCH v4 05/11] tty: 8250: Add support for Intashield IS-100 Cameron Williams
2023-10-24 9:41 ` Ilpo Järvinen
2023-10-24 9:49 ` Greg KH
2023-10-20 16:03 ` [PATCH v4 06/11] tty: 8250: Fix port count of PX-257 Cameron Williams
2023-10-24 9:42 ` Ilpo Järvinen
2023-10-24 9:50 ` Greg Kroah-Hartman
2023-10-24 10:18 ` Cameron Williams
2023-10-20 16:03 ` [PATCH v4 07/11] tty: 8250: Fix up PX-803/PX-857 Cameron Williams
2023-10-20 16:03 ` [PATCH v4 08/11] tty: 8250: Add note for PX-835 Cameron Williams
2023-10-20 16:03 ` [PATCH v4 09/11] tty: 8250: Add support for additional Brainboxes PX cards Cameron Williams
2023-10-20 16:03 ` [PATCH v4 10/11] tty: 8250: Add support for Intashield IX cards Cameron Williams
2023-10-20 16:03 ` [PATCH v4 11/11] tty: 8250: Add Brainboxes Oxford Semiconductor-based quirks Cameron Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102107-poser-recipient-3593@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cang1@live.co.uk \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox