From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B7B4C004C0 for ; Mon, 23 Oct 2023 11:33:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234126AbjJWLdp (ORCPT ); Mon, 23 Oct 2023 07:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234124AbjJWLdo (ORCPT ); Mon, 23 Oct 2023 07:33:44 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7D3CDB for ; Mon, 23 Oct 2023 04:33:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13202C433C7; Mon, 23 Oct 2023 11:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698060822; bh=DVwT7IKpzaVIxS90JOSKktoR8Pi7p0ICdP/SLH7b7WA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Opt//yegts4pdkCgOf7MbNKq7RyKSKlKW7OVUP1cEFvvRLEX9tMr5t7R0MzVR75bl 9pWZ0SH7SS7RQ1VDchxE/nbTsdi4JSfKVy8RRRC9uWO2Gm66BOmXaac9zjlsCI5Elg 1vdGtc2FeQ4b26aQdhwVPUMtIMJzI9kqbp9fZvro= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Andrew Lunn , Jakub Kicinski Subject: [PATCH 5.4 067/123] net: usb: smsc95xx: Fix an error code in smsc95xx_reset() Date: Mon, 23 Oct 2023 12:57:05 +0200 Message-ID: <20231023104819.920660954@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231023104817.691299567@linuxfoundation.org> References: <20231023104817.691299567@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit c53647a5df9e66dd9fedf240198e1fe50d88c286 upstream. Return a negative error code instead of success. Fixes: 2f7ca802bdae ("net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter driver") Signed-off-by: Dan Carpenter Reviewed-by: Andrew Lunn Link: https://lore.kernel.org/r/147927f0-9ada-45cc-81ff-75a19dd30b76@moroto.mountain Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/smsc95xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1040,7 +1040,7 @@ static int smsc95xx_reset(struct usbnet if (timeout >= 100) { netdev_warn(dev->net, "timeout waiting for completion of Lite Reset\n"); - return ret; + return -ETIMEDOUT; } ret = smsc95xx_write_reg(dev, PM_CTRL, PM_CTL_PHY_RST_);