From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0985C004C0 for ; Mon, 23 Oct 2023 11:34:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234032AbjJWLev (ORCPT ); Mon, 23 Oct 2023 07:34:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234033AbjJWLeu (ORCPT ); Mon, 23 Oct 2023 07:34:50 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF3921A4 for ; Mon, 23 Oct 2023 04:34:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AD10C433C9; Mon, 23 Oct 2023 11:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698060888; bh=EiT0zLJMeQa5l4lAzhoHVX6UTs8GZpPxw2IX054FOGw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M5vVNZtg79mCD7AOJtbdQX6tnNvK62r+keTq9AuvLoEGQAwZIbFWd0geeem1OLkiB 2Bj2zRTproszKUiChat/WWKgJQME0EYU+mSzhRFzIwy3VFzgT88BMZWCzIUioWz3sS SnZqe8cXOls9Qh4RsZGsSioH+4sAUG/9QuVCrlOM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Manivannan Sadhasivam , Bibek Kumar Patro , Miquel Raynal Subject: [PATCH 5.4 102/123] mtd: rawnand: qcom: Unmap the right resource upon probe failure Date: Mon, 23 Oct 2023 12:57:40 +0200 Message-ID: <20231023104821.128043522@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231023104817.691299567@linuxfoundation.org> References: <20231023104817.691299567@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bibek Kumar Patro commit 5279f4a9eed3ee7d222b76511ea7a22c89e7eefd upstream. We currently provide the physical address of the DMA region rather than the output of dma_map_resource() which is obviously wrong. Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()") Cc: stable@vger.kernel.org Reviewed-by: Manivannan Sadhasivam Signed-off-by: Bibek Kumar Patro Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20230913070702.12707-1-quic_bibekkum@quicinc.com Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/raw/qcom_nandc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -2972,7 +2972,7 @@ err_nandc_alloc: err_aon_clk: clk_disable_unprepare(nandc->core_clk); err_core_clk: - dma_unmap_resource(dev, res->start, resource_size(res), + dma_unmap_resource(dev, nandc->base_dma, resource_size(res), DMA_BIDIRECTIONAL, 0); return ret; }