From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1C4C001E0 for ; Mon, 23 Oct 2023 11:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbjJWLeg (ORCPT ); Mon, 23 Oct 2023 07:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233951AbjJWLef (ORCPT ); Mon, 23 Oct 2023 07:34:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D484DB for ; Mon, 23 Oct 2023 04:34:34 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58ADAC433C8; Mon, 23 Oct 2023 11:34:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698060873; bh=zlN5DTxS4G2X5Gy0w83tcr3ukZoxJH4RaRDjlG6dZTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BmLUvy8NxDIjkqsBzKJScF06DCBsWP+xKNWytg7Ze7C70cOJj+ICkKt8HaiXJpzZH CPdFz0RzBsheW1f7Li30N8DyCMX+pwxwim52Fn7gLByFszrp/Tb9YUJiV6a8kBXz1P aavIAFOslMAW75yNd4xi3teWuUccQf5vLKY7N6UA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+c90849c50ed209d77689@syzkaller.appspotmail.com, Edward AD , Luiz Augusto von Dentz Subject: [PATCH 5.4 121/123] Bluetooth: hci_sock: fix slab oob read in create_monitor_event Date: Mon, 23 Oct 2023 12:57:59 +0200 Message-ID: <20231023104821.862927993@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231023104817.691299567@linuxfoundation.org> References: <20231023104817.691299567@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Edward AD commit 18f547f3fc074500ab5d419cf482240324e73a7e upstream. When accessing hdev->name, the actual string length should prevail Reported-by: syzbot+c90849c50ed209d77689@syzkaller.appspotmail.com Fixes: dcda165706b9 ("Bluetooth: hci_core: Fix build warnings") Signed-off-by: Edward AD Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Greg Kroah-Hartman --- net/bluetooth/hci_sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/bluetooth/hci_sock.c +++ b/net/bluetooth/hci_sock.c @@ -430,7 +430,7 @@ static struct sk_buff *create_monitor_ev ni->type = hdev->dev_type; ni->bus = hdev->bus; bacpy(&ni->bdaddr, &hdev->bdaddr); - memcpy(ni->name, hdev->name, 8); + memcpy(ni->name, hdev->name, strlen(hdev->name)); opcode = cpu_to_le16(HCI_MON_NEW_INDEX); break;