From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95963CDB474 for ; Mon, 23 Oct 2023 11:25:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233850AbjJWLZq (ORCPT ); Mon, 23 Oct 2023 07:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233942AbjJWLZn (ORCPT ); Mon, 23 Oct 2023 07:25:43 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2918392 for ; Mon, 23 Oct 2023 04:25:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DAA8C433C7; Mon, 23 Oct 2023 11:25:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698060341; bh=AN6s0PRUJnn9dabzlecQv3acwWdMIN1HfJlvphS9xQA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NT/esRfcoZ+ngfRDXwyD2TLpmboiiRtT8iutA979YbQdr/El6AR3wGISjeIiYb2KZ AKGZKc/NonVt9X2MHGIhntJ4RIdlH/Fue/fBaILqTBVK+3IxlBWRI6zkx4xrn5qd7R vUWoUsJISjPzfhtdTlUIesDf+7StWDNSWXy6pSgM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Benjamin Berg , Johannes Berg , Sasha Levin Subject: [PATCH 6.1 113/196] wifi: cfg80211: avoid leaking stack data into trace Date: Mon, 23 Oct 2023 12:56:18 +0200 Message-ID: <20231023104831.715431311@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231023104828.488041585@linuxfoundation.org> References: <20231023104828.488041585@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Benjamin Berg [ Upstream commit 334bf33eec5701a1e4e967bcb7cc8611a998334b ] If the structure is not initialized then boolean types might be copied into the tracing data without being initialised. This causes data from the stack to leak into the trace and also triggers a UBSAN failure which can easily be avoided here. Signed-off-by: Benjamin Berg Link: https://lore.kernel.org/r/20230925171855.a9271ef53b05.I8180bae663984c91a3e036b87f36a640ba409817@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 1d993a490ac4b..b19b5acfaf3a9 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -8289,7 +8289,7 @@ static int nl80211_update_mesh_config(struct sk_buff *skb, struct cfg80211_registered_device *rdev = info->user_ptr[0]; struct net_device *dev = info->user_ptr[1]; struct wireless_dev *wdev = dev->ieee80211_ptr; - struct mesh_config cfg; + struct mesh_config cfg = {}; u32 mask; int err; -- 2.40.1