From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A80BDC001E0 for ; Mon, 23 Oct 2023 09:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229572AbjJWJx7 (ORCPT ); Mon, 23 Oct 2023 05:53:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233232AbjJWJx5 (ORCPT ); Mon, 23 Oct 2023 05:53:57 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66AB9D6 for ; Mon, 23 Oct 2023 02:53:55 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B04F4C433C8; Mon, 23 Oct 2023 09:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698054835; bh=fbD1hvk5O4U8/3qMTMhbc8geYNtL1j8gXDKpKHdEVao=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zCmO2hQFLaB5NAxkVhNYvlasVlf1fpxQguqhq3DlxJmwxkQJ2TA/NNvXKeFgrPDEB fKXoNteMJxsAmPHapfRkANQL0rfzVek0c8i4vRSR8quaNpiBGX+VPHgXvLZwgYSyxg 8dAXA/TUueMSNukwiZdu//XADiNvRPmHM4dC2vkQ= Date: Mon, 23 Oct 2023 11:53:52 +0200 From: Greg Kroah-Hartman To: Lee Jones Cc: stable@vger.kernel.org, Krzysztof Kozlowski , Bjorn Andersson Subject: Re: [PATCH v5.15.y 3/3] rpmsg: Fix kfree() of static memory on setting driver_override Message-ID: <2023102322-fasting-parade-1553@gregkh> References: <20231018120441.2110004-1-lee@kernel.org> <20231018120441.2110004-3-lee@kernel.org> <2023102325-untie-divisibly-8b97@gregkh> <20231023093903.GD8909@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023093903.GD8909@google.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Oct 23, 2023 at 10:39:03AM +0100, Lee Jones wrote: > On Mon, 23 Oct 2023, Greg Kroah-Hartman wrote: > > > On Wed, Oct 18, 2023 at 01:04:34PM +0100, Lee Jones wrote: > > > From: Krzysztof Kozlowski > > > > > > commit 42cd402b8fd4672b692400fe5f9eecd55d2794ac upstream. > > > > > > The driver_override field from platform driver should not be initialized > > > from static memory (string literal) because the core later kfree() it, > > > for example when driver_override is set via sysfs. > > > > > > Use dedicated helper to set driver_override properly. > > > > > > Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver") > > > Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") > > > Reviewed-by: Bjorn Andersson > > > Signed-off-by: Krzysztof Kozlowski > > > Link: https://lore.kernel.org/r/20220419113435.246203-13-krzysztof.kozlowski@linaro.org > > > Signed-off-by: Greg Kroah-Hartman > > > Signed-off-by: Lee Jones > > > --- > > > drivers/rpmsg/rpmsg_internal.h | 13 +++++++++++-- > > > include/linux/rpmsg.h | 6 ++++-- > > > 2 files changed, 15 insertions(+), 4 deletions(-) > > > > Any specific reason why you missed the fixes for this commit as well? > > Turned out to need some more things after this :( > > No reason not to. I didn't notice them. fixes for fixes are important :) > Which patches have you dropped? Just these 3 or all branches? All branches. thanks, greg k-h