From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBF75CDB474 for ; Mon, 23 Oct 2023 08:56:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232478AbjJWI4B (ORCPT ); Mon, 23 Oct 2023 04:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232588AbjJWIz6 (ORCPT ); Mon, 23 Oct 2023 04:55:58 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 244C010C6 for ; Mon, 23 Oct 2023 01:55:55 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FA06C433CA; Mon, 23 Oct 2023 08:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698051354; bh=FhHNb5l1WYaaweAcJGI7Ly1H5wpRaZhCo8TRxnQereU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JlexQ7RQKPD6KaoyJpx23aNo35neLfECwSDZpC2lo1hDOJNWU83Jc4rlQ2riilMvS 4VpCaNLcDCDLTodbKu4FIPWXXpy8wz53LtmvPxOgxcfkSFzlmCHQCt84EKs5gXxd+8 Fe7iPzaZ4SZcFpuhSaOd2CijTjBDkhFxEnxUTVDM= Date: Mon, 23 Oct 2023 10:55:51 +0200 From: Greg Kroah-Hartman To: Lee Jones Cc: stable@vger.kernel.org, Krzysztof Kozlowski , Bjorn Andersson Subject: Re: [PATCH v5.15.y 3/3] rpmsg: Fix kfree() of static memory on setting driver_override Message-ID: <2023102325-untie-divisibly-8b97@gregkh> References: <20231018120441.2110004-1-lee@kernel.org> <20231018120441.2110004-3-lee@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018120441.2110004-3-lee@kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Oct 18, 2023 at 01:04:34PM +0100, Lee Jones wrote: > From: Krzysztof Kozlowski > > commit 42cd402b8fd4672b692400fe5f9eecd55d2794ac upstream. > > The driver_override field from platform driver should not be initialized > from static memory (string literal) because the core later kfree() it, > for example when driver_override is set via sysfs. > > Use dedicated helper to set driver_override properly. > > Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver") > Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") > Reviewed-by: Bjorn Andersson > Signed-off-by: Krzysztof Kozlowski > Link: https://lore.kernel.org/r/20220419113435.246203-13-krzysztof.kozlowski@linaro.org > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Lee Jones > --- > drivers/rpmsg/rpmsg_internal.h | 13 +++++++++++-- > include/linux/rpmsg.h | 6 ++++-- > 2 files changed, 15 insertions(+), 4 deletions(-) Any specific reason why you missed the fixes for this commit as well? Turned out to need some more things after this :( Why are these needed at all for the stable kernels anyway? It's good to have in the tree, but who is using manual overrides for the rpmsg driver in the first place? I'm going to drop all of these from the stable queues now and wait for a fixed up set of patches with a good reason to justify their existence in the stable trees. thanks, greg k-h