From: Greg KH <gregkh@linuxfoundation.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: stable@vger.kernel.org, sashal@kernel.org,
linux-can@vger.kernel.org, lukas.magel@posteo.net,
patches@lists.linux.dev, maxime.jayat@mobile-devices.fr,
mkl@pengutronix.de, michal.sojka@cvut.cz
Subject: Re: [PATCH] can: isotp: upgrade 5.15 LTS to latest 6.6 mainline code base
Date: Mon, 30 Oct 2023 12:38:36 +0100 [thread overview]
Message-ID: <2023103048-riverside-giving-e44d@gregkh> (raw)
In-Reply-To: <20231030113110.3404-1-socketcan@hartkopp.net>
On Mon, Oct 30, 2023 at 12:31:10PM +0100, Oliver Hartkopp wrote:
> The backport of commit 9c5df2f14ee3 ("can: isotp: isotp_ops: fix poll() to
> not report false EPOLLOUT events") introduced a new regression where the
> fix could potentially introduce new side effects.
>
> To reduce the risk of other unmet dependencies and missing fixes and checks
> the latest mainline code base is ported back to the 5.15 LTS tree.
>
> To meet the former Linux 5.15 API these commits have been reverted:
> f4b41f062c42 ("net: remove noblock parameter from skb_recv_datagram()")
> 96a7457a14d9 ("can: skb: unify skb CAN frame identification helpers")
> dc97391e6610 ("sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)")
> 0145462fc802 ("can: isotp: isotp_recvmsg(): use sock_recv_cmsgs() to get SOCK_RXQ_OVFL infos")
>
> New features and communication stability measures:
> 9f39d36530e5 ("can: isotp: add support for transmission without flow control")
> 96d1c81e6a04 ("can: isotp: add module parameter for maximum pdu size")
> 4b7fe92c0690 ("can: isotp: add local echo tx processing for consecutive frames")
> 530e0d46c613 ("can: isotp: set default value for N_As to 50 micro seconds")
Please send these as individual patches, reverts and then the new ones
added, not as one huge commit that we can't review properly at all.
But why just 5.15? What about 6.1.y and 6.5.y?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-30 11:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 11:31 [PATCH] can: isotp: upgrade 5.15 LTS to latest 6.6 mainline code base Oliver Hartkopp
2023-10-30 11:33 ` kernel test robot
2023-10-30 11:38 ` Greg KH [this message]
2023-10-30 12:09 ` Oliver Hartkopp
2023-10-30 12:42 ` Greg KH
2023-10-30 13:40 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023103048-riverside-giving-e44d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-can@vger.kernel.org \
--cc=lukas.magel@posteo.net \
--cc=maxime.jayat@mobile-devices.fr \
--cc=michal.sojka@cvut.cz \
--cc=mkl@pengutronix.de \
--cc=patches@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox