From: Greg KH <gregkh@linuxfoundation.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 5.15 2/2] drm/amd: Disable ASPM for VI w/ all Intel systems
Date: Tue, 31 Oct 2023 15:11:23 +0100 [thread overview]
Message-ID: <2023103103-embellish-tilt-8e64@gregkh> (raw)
In-Reply-To: <d8bbb3b4-25a3-418f-9ebf-545d1d826265@amd.com>
On Tue, Oct 31, 2023 at 08:42:37AM -0500, Mario Limonciello wrote:
> On 10/31/2023 06:51, Greg KH wrote:
> > On Fri, Oct 27, 2023 at 03:39:58AM -0500, Mario Limonciello wrote:
> > > Originally we were quirking ASPM disabled specifically for VI when
> > > used with Alder Lake, but it appears to have problems with Rocket
> > > Lake as well.
> > >
> > > Like we've done in the case of dpm for newer platforms, disable
> > > ASPM for all Intel systems.
> > >
> > > Cc: stable@vger.kernel.org # 5.15+
> > > Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default")
> > > Reported-and-tested-by: Paolo Gentili <paolo.gentili@canonical.com>
> > > Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2036742
> > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > > Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > > (cherry-picked from 64ffd2f1d00c6235dabe9704bbb0d9ce3e28147f)
> > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > > ---
> > > drivers/gpu/drm/amd/amdgpu/vi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Again, what about 6.1.y?
>
> 6.1 & 6.5 queue has it already:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.1/drm-amd-disable-aspm-for-vi-w-all-intel-systems.patch
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.5/drm-amd-disable-aspm-for-vi-w-all-intel-systems.patch
>
> >
> > And why aren't you cc:ing all of the original developers on this patch?
>
> I was just looking to make less noise as they'll get it when it's added to
> the queue. If it should be part of the submission to @stable as well I'll
> make a point to do that in the future.
>
> >
> > I'll drop this series and wait for ones for all relevant trees.
>
> Considering my above comment can you please restore?
No, I need a new patch 1/2 please, please resend both of these, they are
long gone from my queue.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-31 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 8:39 [PATCH 5.15 1/2] drm/amd: Move helper for dynamic speed switch check out of smu13 Mario Limonciello
2023-10-27 8:39 ` [PATCH 5.15 2/2] drm/amd: Disable ASPM for VI w/ all Intel systems Mario Limonciello
2023-10-31 11:51 ` Greg KH
2023-10-31 13:42 ` Mario Limonciello
2023-10-31 14:11 ` Greg KH [this message]
2023-10-31 11:50 ` [PATCH 5.15 1/2] drm/amd: Move helper for dynamic speed switch check out of smu13 Greg KH
2023-10-31 13:44 ` Mario Limonciello
2023-10-31 14:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023103103-embellish-tilt-8e64@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=mario.limonciello@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox