From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F8F7C00142 for ; Tue, 31 Oct 2023 09:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343853AbjJaJ1I (ORCPT ); Tue, 31 Oct 2023 05:27:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343874AbjJaJ1H (ORCPT ); Tue, 31 Oct 2023 05:27:07 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73FFBA3 for ; Tue, 31 Oct 2023 02:27:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7E2CC43391; Tue, 31 Oct 2023 09:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698744423; bh=2cPxJjP8TNP14Bgx/Zg4CW1No8UxMWGSWyyOuMwTpzw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fmCowDR5UPPadmYEx3n7wEZJBeMSaSQjGbNJRDWmi0NN3zWmBziFA7FSYg19QLQwB sCeQrQGOk9SoDphYrLw5NIfc5mnNiySpICf2QZekpuWnw/+wgpP8su6e8W8Xof6rSp LAHBg7mqUxhCtsJFh25BOJFuRQVJYMbsEWrdtWAV4OWu8mMmIAXXt5Cd7OU+MvgZnL EyM92pYJEvL5FRQpQDGZyQErPg5AuSybb88m6LGSGlONj6/fQ0U3dALbRZjhCS+yLk pwTVjpZ5//oi2PYdXylH8VGcoJ6mRQq1RpJ2IAoD+z8fcSHysqAdVvxTURZaIQfQ0D BLjwsxOZkrGtg== From: Lee Jones To: lee@kernel.org Cc: stable@vger.kernel.org, Hangyu Hua , Krzysztof Kozlowski , Mathieu Poirier Subject: [PATCH v5.4.y 6/6] rpmsg: Fix possible refcount leak in rpmsg_register_device_override() Date: Tue, 31 Oct 2023 09:26:40 +0000 Message-ID: <20231031092645.2230861-6-lee@kernel.org> X-Mailer: git-send-email 2.42.0.820.g83a721a137-goog In-Reply-To: <20231031092645.2230861-1-lee@kernel.org> References: <20231031092645.2230861-1-lee@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hangyu Hua commit d7bd416d35121c95fe47330e09a5c04adbc5f928 upstream. rpmsg_register_device_override need to call put_device to free vch when driver_set_override fails. Fix this by adding a put_device() to the error path. Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Hangyu Hua Link: https://lore.kernel.org/r/20220624024120.11576-1-hbh25y@gmail.com Signed-off-by: Mathieu Poirier Signed-off-by: Lee Jones Change-Id: I3c0aae84916f52adcdadff84f101524d09adb51b --- drivers/rpmsg/rpmsg_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 9041d65bc8af6..865d977668cca 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -551,6 +551,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev, strlen(driver_override)); if (ret) { dev_err(dev, "device_set_override failed: %d\n", ret); + put_device(dev); return ret; } } -- 2.42.0.820.g83a721a137-goog