From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF8AC4332F for ; Tue, 31 Oct 2023 09:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343891AbjJaJai (ORCPT ); Tue, 31 Oct 2023 05:30:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343913AbjJaJah (ORCPT ); Tue, 31 Oct 2023 05:30:37 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A819B7 for ; Tue, 31 Oct 2023 02:30:34 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0E5FC433CA; Tue, 31 Oct 2023 09:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698744634; bh=IQVVkI+2JMiiYPzkwKLk7U8zCBDui1QmoGdLhDhbSHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b8cCA7VRYMZGSKBaVmAnK3Ez0/mkvUTAnv0Z4DPqXnk8flcmXvtyMldO8/lUG9myg +JaK21D7dw8PiHLoWAEUf3LlcSCrwehtiyPzZ8aoYdLi8hgmUkiOgOuYydRecVTkaU LK85DFYDBUgjA/h/r+v6wtHp8vCI3OWkGxcw0qKB4iXlGrVkKo7VdSjYjdK1kv8vKv fxSQFe/J1lY6LJwE6XKLwNe9OpUpGrWYdtnfhr9LyniGZidY0QbqY7jjWibS5nUWIo EUXJYKpr/CMJlfrPozw/K3rWXNSmenMYJdIu9HvDuPE7kPv2AvWeIiy/LSJEvdSG5o 2FVlwiKkbo28w== From: Lee Jones To: lee@kernel.org Cc: stable@vger.kernel.org, Hangyu Hua , Krzysztof Kozlowski , Mathieu Poirier Subject: [PATCH v4.19.y 6/6] rpmsg: Fix possible refcount leak in rpmsg_register_device_override() Date: Tue, 31 Oct 2023 09:30:15 +0000 Message-ID: <20231031093018.2233640-6-lee@kernel.org> X-Mailer: git-send-email 2.42.0.820.g83a721a137-goog In-Reply-To: <20231031093018.2233640-1-lee@kernel.org> References: <20231031093018.2233640-1-lee@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hangyu Hua commit d7bd416d35121c95fe47330e09a5c04adbc5f928 upstream. rpmsg_register_device_override need to call put_device to free vch when driver_set_override fails. Fix this by adding a put_device() to the error path. Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Hangyu Hua Link: https://lore.kernel.org/r/20220624024120.11576-1-hbh25y@gmail.com Signed-off-by: Mathieu Poirier Signed-off-by: Lee Jones Change-Id: I38b3e338ed57bc27d8818be9c166f52762973db3 --- drivers/rpmsg/rpmsg_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 3d6427b0edc41..880c7c4deec30 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -550,6 +550,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev, strlen(driver_override)); if (ret) { dev_err(dev, "device_set_override failed: %d\n", ret); + put_device(dev); return ret; } } -- 2.42.0.820.g83a721a137-goog