From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B550C4167B for ; Tue, 31 Oct 2023 11:38:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343798AbjJaLiL (ORCPT ); Tue, 31 Oct 2023 07:38:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343783AbjJaLiL (ORCPT ); Tue, 31 Oct 2023 07:38:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 152E2C2 for ; Tue, 31 Oct 2023 04:38:09 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90F45C433D9; Tue, 31 Oct 2023 11:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698752288; bh=FYmFMpl622g+9WggLpQSghcZ2odaNeXX8CQoRQUQiMA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VC+BmTTJlrIE8zNgEtN2f3zEEvpEiZY28CJqZpRO6eM5n/6RMCp9UFovQq3UYOAPB t8fsUVyblUfzpmrb5kUiCDxPDZwzJtUf+zADHQbe6yVcOuSR9vD6Ls2mpnL9JC/Q0S xOzi/sE9ayFiYsX60HdNzBKrIqo/V2JLu6a569MQFIWkJiOskTPY3DhSrjVoqK+m+r k1mEmJ0XZZNfGOTtFVit+Zsetyoad4/v9M1t2swXj7qp0YyghJ7QYejTL+lz0bQJRH hz2IJLvsdbiFF8+JM52RafDK9clK/E6RkUWWd3QDvaaH4BzaL2tBJO7Cc0lo+Q3aqG 5NBA5UnQ1gHZw== From: Lee Jones To: lee@kernel.org Cc: stable@vger.kernel.org, Hangyu Hua , Krzysztof Kozlowski , Mathieu Poirier Subject: [PATCH v5.4.y 6/6] rpmsg: Fix possible refcount leak in rpmsg_register_device_override() Date: Tue, 31 Oct 2023 11:37:48 +0000 Message-ID: <20231031113751.2284727-6-lee@kernel.org> X-Mailer: git-send-email 2.42.0.820.g83a721a137-goog In-Reply-To: <20231031113751.2284727-1-lee@kernel.org> References: <20231031113751.2284727-1-lee@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hangyu Hua commit d7bd416d35121c95fe47330e09a5c04adbc5f928 upstream. rpmsg_register_device_override need to call put_device to free vch when driver_set_override fails. Fix this by adding a put_device() to the error path. Fixes: bb17d110cbf2 ("rpmsg: Fix calling device_lock() on non-initialized device") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Hangyu Hua Link: https://lore.kernel.org/r/20220624024120.11576-1-hbh25y@gmail.com Signed-off-by: Mathieu Poirier Signed-off-by: Lee Jones --- drivers/rpmsg/rpmsg_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 9041d65bc8af6..865d977668cca 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -551,6 +551,7 @@ int rpmsg_register_device_override(struct rpmsg_device *rpdev, strlen(driver_override)); if (ret) { dev_err(dev, "device_set_override failed: %d\n", ret); + put_device(dev); return ret; } } -- 2.42.0.820.g83a721a137-goog