From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A97BDC4167D for ; Tue, 31 Oct 2023 11:40:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343822AbjJaLkF (ORCPT ); Tue, 31 Oct 2023 07:40:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343743AbjJaLkE (ORCPT ); Tue, 31 Oct 2023 07:40:04 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C981191 for ; Tue, 31 Oct 2023 04:40:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EA45C433CB; Tue, 31 Oct 2023 11:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698752402; bh=ztpp06yHe8DpDQ/OG4siubPj6++HrvnaDG3CBDolUzU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EGNpuzKar0Jdmc4Rl0Ii5bmLTOeRY3PC4Pvq9KIuTubtMB/avgItDZpR53TRSF0gu y3lOiCst7xk0nE+3MC7RCNXMCbtFgtcQTWq0ysOdJ2PfJIVgDh4nxjhe2jgsKZF8lC 14w17nCH+yFgvjavsL5ZCZ5+HKgohd5wiJmPMbCkqR6mUraXRQd6HUrLMlDM3JB/0C //dk1PYR5eQpd5UhzIIm6BzDhJBFp3G98epclAFBR+9dhv4FkvoCh5iADD0P9o5WLM K4len/wX3bGMlrFEYIG1ArVzAg9oeulMt49NgdIVco5oXDK1ybYu91ND0SGm3fuq3R soAhCkcl3uTOw== From: Lee Jones To: lee@kernel.org Cc: stable@vger.kernel.org, Krzysztof Kozlowski , Greg Kroah-Hartman Subject: [PATCH v4.19.y 2/6] rpmsg: Constify local variable in field store macro Date: Tue, 31 Oct 2023 11:39:48 +0000 Message-ID: <20231031113956.2287681-2-lee@kernel.org> X-Mailer: git-send-email 2.42.0.820.g83a721a137-goog In-Reply-To: <20231031113956.2287681-1-lee@kernel.org> References: <20231031113956.2287681-1-lee@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Krzysztof Kozlowski commit e5f89131a06142e91073b6959d91cea73861d40e upstream. Memory pointed by variable 'old' in field store macro is not modified, so it can be made a pointer to const. Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20220419113435.246203-12-krzysztof.kozlowski@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Lee Jones --- drivers/rpmsg/rpmsg_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 65834153ba977..19c7df92c63e0 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -332,7 +332,8 @@ field##_store(struct device *dev, struct device_attribute *attr, \ const char *buf, size_t sz) \ { \ struct rpmsg_device *rpdev = to_rpmsg_device(dev); \ - char *new, *old; \ + const char *old; \ + char *new; \ \ new = kstrndup(buf, sz, GFP_KERNEL); \ if (!new) \ -- 2.42.0.820.g83a721a137-goog