[PATCH 5.15 1/2] drm/amd: Move helper for dynamic speed switch check out of smu13

[PATCH 5.15 1/2] drm/amd: Move helper for dynamic speed switch check out of smu13

[Mario Limonciello]

This helper is used for checking if the connected host supports
the feature, it can be moved into generic code to be used by other
smu implementations as well.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 5d1eb4c4c872b55664f5754cc16827beff8630a7)

The original problematic dGPU is not supported in 5.15.

Just introduce new function for 5.15 as a dependency for fixing
unrelated dGPU that uses this symbol as well.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h        |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index d90da384d185..1f1e7966beb5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -1285,6 +1285,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
 void amdgpu_device_pci_config_reset(struct amdgpu_device *adev);
 int amdgpu_device_pci_reset(struct amdgpu_device *adev);
 bool amdgpu_device_need_post(struct amdgpu_device *adev);
+bool amdgpu_device_pcie_dynamic_switching_supported(void);
 bool amdgpu_device_should_use_aspm(struct amdgpu_device *adev);
 bool amdgpu_device_aspm_support_quirk(void);
 
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 2cf49a32ac6c..f57334fff7fc 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1319,6 +1319,25 @@ bool amdgpu_device_need_post(struct amdgpu_device *adev)
 	return true;
 }
 
+/*
+ * Intel hosts such as Raptor Lake and Sapphire Rapids don't support dynamic
+ * speed switching. Until we have confirmation from Intel that a specific host
+ * supports it, it's safer that we keep it disabled for all.
+ *
+ * https://edc.intel.com/content/www/us/en/design/products/platforms/details/raptor-lake-s/13th-generation-core-processors-datasheet-volume-1-of-2/005/pci-express-support/
+ * https://gitlab.freedesktop.org/drm/amd/-/issues/2663
+ */
+bool amdgpu_device_pcie_dynamic_switching_supported(void)
+{
+#if IS_ENABLED(CONFIG_X86)
+	struct cpuinfo_x86 *c = &cpu_data(0);
+
+	if (c->x86_vendor == X86_VENDOR_INTEL)
+		return false;
+#endif
+	return true;
+}
+
 /**
  * amdgpu_device_should_use_aspm - check if the device should program ASPM
  *
-- 
2.34.1

[PATCH 5.15 2/2] drm/amd: Disable ASPM for VI w/ all Intel systems

[Mario Limonciello]

Originally we were quirking ASPM disabled specifically for VI when
used with Alder Lake, but it appears to have problems with Rocket
Lake as well.

Like we've done in the case of dpm for newer platforms, disable
ASPM for all Intel systems.

Cc: stable@vger.kernel.org # 5.15+
Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default")
Reported-and-tested-by: Paolo Gentili <paolo.gentili@canonical.com>
Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2036742
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry-picked from 64ffd2f1d00c6235dabe9704bbb0d9ce3e28147f)
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/vi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index b9555ba6d32f..6d64d603a97a 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -1147,7 +1147,7 @@ static void vi_program_aspm(struct amdgpu_device *adev)
 	bool bL1SS = false;
 	bool bClkReqSupport = true;
 
-	if (!amdgpu_device_should_use_aspm(adev) || !amdgpu_device_aspm_support_quirk())
+	if (!amdgpu_device_should_use_aspm(adev) || !amdgpu_device_pcie_dynamic_switching_supported())
 		return;
 
 	if (adev->flags & AMD_IS_APU ||
-- 
2.34.1

Re: [PATCH 5.15 1/2] drm/amd: Move helper for dynamic speed switch check out of smu13

[Greg KH]

On Fri, Oct 27, 2023 at 03:39:57AM -0500, Mario Limonciello wrote:
> This helper is used for checking if the connected host supports
> the feature, it can be moved into generic code to be used by other
> smu implementations as well.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> Reviewed-by: Evan Quan <evan.quan@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> (cherry picked from commit 5d1eb4c4c872b55664f5754cc16827beff8630a7)
> 
> The original problematic dGPU is not supported in 5.15.
> 
> Just introduce new function for 5.15 as a dependency for fixing
> unrelated dGPU that uses this symbol as well.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h        |  1 +
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 +++++++++++++++++++
>  2 files changed, 20 insertions(+)

What about 6.5 and 6.1 for this commit?  We can't have someone upgrade
and have a regression, right?

thanks

greg k-h

Re: [PATCH 5.15 2/2] drm/amd: Disable ASPM for VI w/ all Intel systems

[Greg KH]

On Fri, Oct 27, 2023 at 03:39:58AM -0500, Mario Limonciello wrote:
> Originally we were quirking ASPM disabled specifically for VI when
> used with Alder Lake, but it appears to have problems with Rocket
> Lake as well.
> 
> Like we've done in the case of dpm for newer platforms, disable
> ASPM for all Intel systems.
> 
> Cc: stable@vger.kernel.org # 5.15+
> Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default")
> Reported-and-tested-by: Paolo Gentili <paolo.gentili@canonical.com>
> Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2036742
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> (cherry-picked from 64ffd2f1d00c6235dabe9704bbb0d9ce3e28147f)
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/vi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Again, what about 6.1.y?

And why aren't you cc:ing all of the original developers on this patch?

I'll drop this series and wait for ones for all relevant trees.

thanks,

greg k-h

Re: [PATCH 5.15 2/2] drm/amd: Disable ASPM for VI w/ all Intel systems

[Mario Limonciello]

On 10/31/2023 06:51, Greg KH wrote:
> On Fri, Oct 27, 2023 at 03:39:58AM -0500, Mario Limonciello wrote:
>> Originally we were quirking ASPM disabled specifically for VI when
>> used with Alder Lake, but it appears to have problems with Rocket
>> Lake as well.
>>
>> Like we've done in the case of dpm for newer platforms, disable
>> ASPM for all Intel systems.
>>
>> Cc: stable@vger.kernel.org # 5.15+
>> Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default")
>> Reported-and-tested-by: Paolo Gentili <paolo.gentili@canonical.com>
>> Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2036742
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>> (cherry-picked from 64ffd2f1d00c6235dabe9704bbb0d9ce3e28147f)
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/vi.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Again, what about 6.1.y?

6.1 & 6.5 queue has it already:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.1/drm-amd-disable-aspm-for-vi-w-all-intel-systems.patch
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.5/drm-amd-disable-aspm-for-vi-w-all-intel-systems.patch

> 
> And why aren't you cc:ing all of the original developers on this patch?

I was just looking to make less noise as they'll get it when it's added 
to the queue.  If it should be part of the submission to @stable as well 
I'll make a point to do that in the future.

> 
> I'll drop this series and wait for ones for all relevant trees.

Considering my above comment can you please restore?

> 
> thanks,
> 
> greg k-h

Re: [PATCH 5.15 1/2] drm/amd: Move helper for dynamic speed switch check out of smu13

[Mario Limonciello]

On 10/31/2023 06:50, Greg KH wrote:
> On Fri, Oct 27, 2023 at 03:39:57AM -0500, Mario Limonciello wrote:
>> This helper is used for checking if the connected host supports
>> the feature, it can be moved into generic code to be used by other
>> smu implementations as well.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> Reviewed-by: Evan Quan <evan.quan@amd.com>
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>> (cherry picked from commit 5d1eb4c4c872b55664f5754cc16827beff8630a7)
>>
>> The original problematic dGPU is not supported in 5.15.
>>
>> Just introduce new function for 5.15 as a dependency for fixing
>> unrelated dGPU that uses this symbol as well.
>>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        |  1 +
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 +++++++++++++++++++
>>   2 files changed, 20 insertions(+)
> 
> What about 6.5 and 6.1 for this commit?  We can't have someone upgrade
> and have a regression, right?
> 
> thanks
> 
> greg k-h

Kernel 6.5-rc2 introduced this commit.

Kernel 6.1.y already has this commit.  Here's the hash:

32631ac27c91 ("drm/amd: Move helper for dynamic speed switch check out 
of smu13")

Re: [PATCH 5.15 1/2] drm/amd: Move helper for dynamic speed switch check out of smu13

[Greg KH]

On Tue, Oct 31, 2023 at 08:44:42AM -0500, Mario Limonciello wrote:
> On 10/31/2023 06:50, Greg KH wrote:
> > On Fri, Oct 27, 2023 at 03:39:57AM -0500, Mario Limonciello wrote:
> > > This helper is used for checking if the connected host supports
> > > the feature, it can be moved into generic code to be used by other
> > > smu implementations as well.
> > > 
> > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > > Reviewed-by: Evan Quan <evan.quan@amd.com>
> > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > > (cherry picked from commit 5d1eb4c4c872b55664f5754cc16827beff8630a7)
> > > 
> > > The original problematic dGPU is not supported in 5.15.
> > > 
> > > Just introduce new function for 5.15 as a dependency for fixing
> > > unrelated dGPU that uses this symbol as well.
> > > 
> > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > > ---
> > >   drivers/gpu/drm/amd/amdgpu/amdgpu.h        |  1 +
> > >   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 +++++++++++++++++++
> > >   2 files changed, 20 insertions(+)
> > 
> > What about 6.5 and 6.1 for this commit?  We can't have someone upgrade
> > and have a regression, right?
> > 
> > thanks
> > 
> > greg k-h
> 
> Kernel 6.5-rc2 introduced this commit.
> 
> Kernel 6.1.y already has this commit.  Here's the hash:
> 
> 32631ac27c91 ("drm/amd: Move helper for dynamic speed switch check out of
> smu13")

Then the commit listed above is wrong in the patch, please fix up and
resend the series with the correct id.

Yet-another-problem due to the drm layer having duplicate commits in
their trees, sorry, you all did it to yourself...

greg k-h

Re: [PATCH 5.15 2/2] drm/amd: Disable ASPM for VI w/ all Intel systems

[Greg KH]

On Tue, Oct 31, 2023 at 08:42:37AM -0500, Mario Limonciello wrote:
> On 10/31/2023 06:51, Greg KH wrote:
> > On Fri, Oct 27, 2023 at 03:39:58AM -0500, Mario Limonciello wrote:
> > > Originally we were quirking ASPM disabled specifically for VI when
> > > used with Alder Lake, but it appears to have problems with Rocket
> > > Lake as well.
> > > 
> > > Like we've done in the case of dpm for newer platforms, disable
> > > ASPM for all Intel systems.
> > > 
> > > Cc: stable@vger.kernel.org # 5.15+
> > > Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default")
> > > Reported-and-tested-by: Paolo Gentili <paolo.gentili@canonical.com>
> > > Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2036742
> > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > > Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > > (cherry-picked from 64ffd2f1d00c6235dabe9704bbb0d9ce3e28147f)
> > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > > ---
> > >   drivers/gpu/drm/amd/amdgpu/vi.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Again, what about 6.1.y?
> 
> 6.1 & 6.5 queue has it already:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.1/drm-amd-disable-aspm-for-vi-w-all-intel-systems.patch
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.5/drm-amd-disable-aspm-for-vi-w-all-intel-systems.patch
> 
> > 
> > And why aren't you cc:ing all of the original developers on this patch?
> 
> I was just looking to make less noise as they'll get it when it's added to
> the queue.  If it should be part of the submission to @stable as well I'll
> make a point to do that in the future.
> 
> > 
> > I'll drop this series and wait for ones for all relevant trees.
> 
> Considering my above comment can you please restore?

No, I need a new patch 1/2 please, please resend both of these, they are
long gone from my queue.

thanks,

greg k-h