From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C71A3C4332F for ; Fri, 3 Nov 2023 16:00:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343579AbjKCQAK (ORCPT ); Fri, 3 Nov 2023 12:00:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344231AbjKCQAJ (ORCPT ); Fri, 3 Nov 2023 12:00:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 618B4133 for ; Fri, 3 Nov 2023 09:00:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AF32C433C8; Fri, 3 Nov 2023 16:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1699027202; bh=ho11Ufi7y50dDLmR9HnA6SZk/X8G07c2NCDyxJJmKa0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kqe0F35K5yFhkTVfOxOUNfiDiQGclRX6OLCmHCD6XB8W/HxEBWa/zamCHUoRlPLHa A/W4rBzSykwaue7qtAV6VjFvaAP7Pdhgrb/E/Ce6EHdZuqGHcT3QbNxpeZZk/qq2Mz Q8+IuO5lI/mW9956b5YxQWFFHqHpUubGHoIQQ40g= Date: Fri, 3 Nov 2023 16:59:59 +0100 From: Greg Kroah-Hartman To: Naresh Kamboju Cc: linux-stable , lkft-triage@lists.linaro.org, Sasha Levin , Nathan Chancellor , Josh Poimboeuf , Peter Zijlstra Subject: Re: stable-rc: 4.14 and 4.19: arch/x86/kernel/head_32.S:126: Error: invalid character '(' in mnemonic Message-ID: <2023110344-endeared-wrongful-44b3@gregkh> References: <2023110339-voyage-subtype-e34e@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023110339-voyage-subtype-e34e@gregkh> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Nov 03, 2023 at 04:57:40PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 03, 2023 at 09:07:32PM +0530, Naresh Kamboju wrote: > > Following warnings and errors have been noticed while building i386 build > > on stable-rc linux.4.19.y and linux.4.14.y. > > > > Reported-by: Linux Kernel Functional Testing > > > > Build log: > > ========== > > kernel/profile.c: In function 'profile_dead_cpu': > > kernel/profile.c:346:27: warning: the comparison will always evaluate > > as 'true' for the address of 'prof_cpu_mask' will never be NULL > > [-Waddress] > > 346 | if (prof_cpu_mask != NULL) > > | ^~ > > kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here > > 49 | static cpumask_var_t prof_cpu_mask; > > | ^~~~~~~~~~~~~ > > kernel/profile.c: In function 'profile_online_cpu': > > kernel/profile.c:383:27: warning: the comparison will always evaluate > > as 'true' for the address of 'prof_cpu_mask' will never be NULL > > [-Waddress] > > 383 | if (prof_cpu_mask != NULL) > > | ^~ > > kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here > > 49 | static cpumask_var_t prof_cpu_mask; > > | ^~~~~~~~~~~~~ > > kernel/profile.c: In function 'profile_tick': > > kernel/profile.c:413:47: warning: the comparison will always evaluate > > as 'true' for the address of 'prof_cpu_mask' will never be NULL > > [-Waddress] > > 413 | if (!user_mode(regs) && prof_cpu_mask != NULL && > > | ^~ > > kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here > > 49 | static cpumask_var_t prof_cpu_mask; > > | ^~~~~~~~~~~~~ > > Those are not due to this set of patches, right? > > > arch/x86/kernel/head_32.S: Assembler messages: > > arch/x86/kernel/head_32.S:126: Error: invalid character '(' in mnemonic > > arch/x86/kernel/head_32.S:57: Info: macro invoked from here > > arch/x86/kernel/head_32.S:128: Error: invalid character '(' in mnemonic > > arch/x86/kernel/head_32.S:57: Info: macro invoked from here > > This is odd, nothing touches this file either. > > 7e09ac27f43b ("x86: Fix .brk attribute in linker script") is backported > here, perhaps that is the issue? If you revert that, does the error go > away? Nope, that's not the issue. > Let me see if I can build a 32 bit kernel anymore... I can do this now, let me figure it out... thanks, greg k-h